Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: replace callback function with arrow function #24531

Closed
wants to merge 1 commit into from
Closed

test: replace callback function with arrow function #24531

wants to merge 1 commit into from

Conversation

potham
Copy link
Contributor

@potham potham commented Nov 20, 2018

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Nov 20, 2018
Trott
Trott previously requested changes Nov 20, 2018
View reviewed changes
Copy link
Member

@Trott Trott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The two commits here seem unrelated. Can you please remove the one you did not intend to include? Thanks.

@gireeshpunathil gireeshpunathil added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Nov 21, 2018
@potham
Copy link
Contributor Author

potham commented Nov 21, 2018

@Trott I have removed the unrelated commit from this PR. Please excuse me..

@Trott Trott dismissed their stale review November 21, 2018 06:50

unrelated change removed

@Trott
Copy link
Member

Trott commented Nov 22, 2018

CI: https://ci.nodejs.org/job/node-test-pull-request/18865/

@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Nov 22, 2018
@gireeshpunathil
Copy link
Member

Resume CI: https://ci.nodejs.org/job/node-test-commit-windows-fanned/22625/

@Trott
Copy link
Member

Trott commented Nov 22, 2018

Resume Build CI: https://ci.nodejs.org/job/node-test-commit-windows-fanned/22638/

@gireeshpunathil
Copy link
Member

last CI succeeded, landing.

@gireeshpunathil
Copy link
Member

landed as f85b435

gireeshpunathil pushed a commit that referenced this pull request Nov 23, 2018
@potham @gireeshpunathil
test: replace callback with arrow function
f85b435 
PR-URL: #24531
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
targos pushed a commit that referenced this pull request Nov 24, 2018
@potham @targos
test: replace callback with arrow function
4c641ab 
PR-URL: #24531
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
rvagg pushed a commit that referenced this pull request Nov 28, 2018
@potham @rvagg
test: replace callback with arrow function
2a67a49 
PR-URL: #24531
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
@BridgeAR BridgeAR mentioned this pull request Dec 5, 2018
Merged
4 tasks
This was referenced Dec 7, 2018
Closed
Closed
Closed
Closed
Closed
codebytere pushed a commit that referenced this pull request Jan 13, 2019
@potham @codebytere
test: replace callback with arrow function
d4a24e2 
PR-URL: #24531
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
refack pushed a commit to refack/node that referenced this pull request Jan 14, 2019
@potham @refack
test: replace callback with arrow function
daa68af 
PR-URL: nodejs#24531
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
@codebytere codebytere mentioned this pull request Jan 15, 2019
Merged
codebytere pushed a commit that referenced this pull request Jan 29, 2019
@potham @codebytere
test: replace callback with arrow function
ec0a84e 
PR-URL: #24531
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
codebytere pushed a commit that referenced this pull request Jan 29, 2019
@potham @codebytere
test: replace callback with arrow function
c65063d 
PR-URL: #24531
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
This was referenced Jan 29, 2019
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes

@cjihrig cjihrig cjihrig approved these changes

@Trott Trott Trott left review comments

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@potham @Trott @gireeshpunathil @cjihrig @nodejs-github-bot