Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: swap actual&optional params #24426

Closed
wants to merge 1 commit into from
Closed

test: swap actual&optional params #24426

wants to merge 1 commit into from

Conversation

m-nikhil
Copy link
Contributor

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Nov 17, 2018
@m-nikhil
Copy link
Contributor Author

@ryzokuken @BridgeAR - Please do merge this PR done during Code and Learn.
Assignment name - #JSASSERT11

@gireeshpunathil gireeshpunathil added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Nov 17, 2018
targos
targos approved these changes Nov 17, 2018
View reviewed changes
Copy link
Member

@targos targos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change LGTM.

Commit message should look like test: swap actual and expected parameters (nothing is optional)

@targos targos added the fast-track PRs that do not need to wait for 48 hours to land. label Nov 17, 2018
@targos
Copy link
Member

targos commented Nov 17, 2018

👍 to fast-track

@gireeshpunathil
Copy link
Member

CI: https://ci.nodejs.org/job/node-test-pull-request/18721/

ryzokuken
ryzokuken approved these changes Nov 18, 2018
View reviewed changes
Copy link
Contributor

@ryzokuken ryzokuken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, @m-nikhil!

@targos the committer could amend the commit message, I guess?

@Trott
Copy link
Member

Trott commented Nov 18, 2018

Landed in 1b75b81.

Thanks for the contribution! 🎉

(If you're interested in other possible contributions to Node.js but don't have a good idea of where to start looking, some ideas are posted at https://www.nodetodo.org/next-steps/.)

@Trott Trott closed this Nov 18, 2018
Trott pushed a commit to Trott/io.js that referenced this pull request Nov 18, 2018
@m-nikhil @Trott
test: swap actual&optional params
1b75b81 
PR-URL: nodejs#24426
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Ujjwal Sharma <[email protected]>
targos pushed a commit that referenced this pull request Nov 19, 2018
@m-nikhil @targos
test: swap actual&optional params
feb36f6 
PR-URL: #24426
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Ujjwal Sharma <[email protected]>
rvagg pushed a commit that referenced this pull request Nov 28, 2018
@m-nikhil @rvagg
test: swap actual&optional params
658df6b 
PR-URL: #24426
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Ujjwal Sharma <[email protected]>
@BridgeAR BridgeAR mentioned this pull request Dec 5, 2018
Merged
4 tasks
This was referenced Dec 7, 2018
Closed
Closed
Closed
Closed
Closed
codebytere pushed a commit that referenced this pull request Jan 13, 2019
@m-nikhil @codebytere
test: swap actual&optional params
e77a4c6 
PR-URL: #24426
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Ujjwal Sharma <[email protected]>
refack pushed a commit to refack/node that referenced this pull request Jan 14, 2019
@m-nikhil @refack
test: swap actual&optional params
bef6716 
PR-URL: nodejs#24426
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Ujjwal Sharma <[email protected]>
@codebytere codebytere mentioned this pull request Jan 15, 2019
Merged
codebytere pushed a commit that referenced this pull request Jan 29, 2019
@m-nikhil @codebytere
test: swap actual&optional params
bf3bed5 
PR-URL: #24426
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Ujjwal Sharma <[email protected]>
This was referenced Jan 29, 2019
Closed
Closed
This was referenced Jan 29, 2019
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trivikr trivikr trivikr approved these changes

@ryzokuken ryzokuken ryzokuken approved these changes

@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes

@cjihrig cjihrig cjihrig approved these changes

@targos targos targos approved these changes

Assignees
No one assigned
Labels
code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. fast-track PRs that do not need to wait for 48 hours to land. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@m-nikhil @targos @gireeshpunathil @Trott @cjihrig @ryzokuken @trivikr @nodejs-github-bot