repl: handle buffered string logic on finish #24389
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
readline
|
@nodejs/repl |
|
Who do we need to cc to not forget including this fix in the security release that will be created soon? |
|
@vsemozhetbyt Oh if this gets included in that release, it will be great :) Thanks for the follow up. |
jdalton
reviewed
Nov 18, 2018
antsmartian
force-pushed
the
repl-history
branch
from
8e33b3a
to
2c179f3
Compare
jasnell
approved these changes
Nov 19, 2018
Fishrock123
approved these changes
Nov 19, 2018
vsemozhetbyt
added
the
author ready
|
@vsemozhetbyt You are super fast :) |
|
Bleh, some unrelated ARM failure. Thanks, landed in eb42c1e. (Hopefully I did that right... been an awfully long time since I landed anything...) |
Fishrock123
pushed a commit
that referenced
this pull request
Nov 19, 2018
Looks like `clearBufferedCommand` will be called on almost all flows. Hence history was broken. PR-URL: #24389 Fixes: #24385 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Jeremiah Senkpiel <[email protected]>
|
Made an issue about the ARM failure (a crash): #24496 |
Fishrock123
pushed a commit
that referenced
this pull request
Nov 19, 2018
Looks like `clearBufferedCommand` will be called on almost all flows. Hence history was broken. PR-URL: #24389 Fixes: #24385 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Jeremiah Senkpiel <[email protected]>
|
Landed on 11.x in c11d345 |
targos
pushed a commit
that referenced
this pull request
Nov 19, 2018
Looks like `clearBufferedCommand` will be called on almost all flows. Hence history was broken. PR-URL: #24389 Fixes: #24385 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Jeremiah Senkpiel <[email protected]>
|
Thanks @Fishrock123 |
|
@Fishrock123 v11.x should only be updated when a release is merged. Can you force push to remove the commit? |
|
I fixed it, but had to temporarily unprotect the release branches to do so. |
|
@Fishrock123 No worries, btw :) I opened an issue in the Release repo to discuss a way to prevent this mistake in the future: nodejs/Release#392 |
3 tasks
rvagg
pushed a commit
that referenced
this pull request
Nov 28, 2018
Looks like `clearBufferedCommand` will be called on almost all flows. Hence history was broken. PR-URL: #24389 Fixes: #24385 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Jeremiah Senkpiel <[email protected]>
This was referenced Dec 7, 2018
refack
pushed a commit
to refack/node
that referenced
this pull request
Jan 14, 2019
Looks like `clearBufferedCommand` will be called on almost all flows. Hence history was broken. PR-URL: nodejs#24389 Fixes: nodejs#24385 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Jeremiah Senkpiel <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes : #24385
Looks like
clearBufferedCommandwill be called on almost all flows. Hence history was broken. Sorry about that, but I take this as learning and see why history test cases didn't catch up this in first place. I will spend some time this weekend to add few more test cases on to repl history which caused this regression.Can some one ping repl team to make it land faster?
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes