Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: remove argument and fix import #24375

Closed
wants to merge 3 commits into from
Closed

test: remove argument and fix import #24375

wants to merge 3 commits into from

Conversation

jkmdev
Copy link
Contributor

@jkmdev jkmdev commented Nov 15, 2018

Removes unused argument and uses destructuring for spawn import in test-pipewrap.js.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added async_hooks Issues and PRs related to the async hooks subsystem. test Issues and PRs related to the tests. labels Nov 15, 2018
@Trott
Copy link
Member

Trott commented Nov 15, 2018

CI: https://ci.nodejs.org/job/node-test-pull-request/18628/

@Trott
Copy link
Member

Trott commented Nov 15, 2018 •
edited
Loading

Resume Build CI: https://ci.nodejs.org/job/node-test-pull-request/18644/

@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Nov 16, 2018
@Trott
Copy link
Member

Trott commented Nov 17, 2018 •
edited
Loading

Landed in 07a7bf7.

Thanks for the contribution! 🎉

(If you're interested in other possible contributions to Node.js but don't have a good idea of where to start looking, some ideas are posted at https://www.nodetodo.org/next-steps/.)

@Trott Trott closed this Nov 17, 2018
Trott pushed a commit to Trott/io.js that referenced this pull request Nov 17, 2018
@jkmdev @Trott
test: use destructuring and remove unused arguments
07a7bf7 
Use destructuring consistently and remove unused function arguments in
test-pipewrap.js

PR-URL: nodejs#24375
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Weijia Wang <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Sakthipriyan Vairamani <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Franziska Hinkelmann <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
targos pushed a commit that referenced this pull request Nov 18, 2018
@jkmdev @targos
test: use destructuring and remove unused arguments
20cdf24 
Use destructuring consistently and remove unused function arguments in
test-pipewrap.js

PR-URL: #24375
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Weijia Wang <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Sakthipriyan Vairamani <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Franziska Hinkelmann <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
rvagg pushed a commit that referenced this pull request Nov 28, 2018
@jkmdev @rvagg
test: use destructuring and remove unused arguments
7e2a284 
Use destructuring consistently and remove unused function arguments in
test-pipewrap.js

PR-URL: #24375
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Weijia Wang <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Sakthipriyan Vairamani <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Franziska Hinkelmann <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
@BridgeAR BridgeAR mentioned this pull request Dec 5, 2018
Merged
4 tasks
This was referenced Dec 7, 2018
Closed
Closed
Closed
Closed
Closed
codebytere pushed a commit that referenced this pull request Jan 12, 2019
@jkmdev @codebytere
test: use destructuring and remove unused arguments
8ac75c8 
Use destructuring consistently and remove unused function arguments in
test-pipewrap.js

PR-URL: #24375
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Weijia Wang <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Sakthipriyan Vairamani <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Franziska Hinkelmann <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
@codebytere codebytere mentioned this pull request Jan 15, 2019
Merged
codebytere pushed a commit that referenced this pull request Jan 29, 2019
@jkmdev @codebytere
test: use destructuring and remove unused arguments
3b6135f 
Use destructuring consistently and remove unused function arguments in
test-pipewrap.js

PR-URL: #24375
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Weijia Wang <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Sakthipriyan Vairamani <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Franziska Hinkelmann <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
@beevelop beevelop mentioned this pull request Jan 29, 2019
Closed
This was referenced Jan 29, 2019
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trivikr trivikr trivikr approved these changes

@starkwang starkwang starkwang approved these changes

@cjihrig cjihrig cjihrig approved these changes

@lpinca lpinca lpinca approved these changes

@Trott Trott Trott approved these changes

@thefourtheye thefourtheye thefourtheye approved these changes

@fhinkel fhinkel fhinkel approved these changes

Assignees
No one assigned
Labels
async_hooks Issues and PRs related to the async hooks subsystem. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@jkmdev @Trott @fhinkel @thefourtheye @lpinca @cjihrig @starkwang @trivikr @nodejs-github-bot