-
Notifications
You must be signed in to change notification settings - Fork 29.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
http2: add test for head request is not finished #24308
Conversation
8cb5560
to
75d254a
Compare
@ronag I’ve added the WIP label, feel free to ask for it to be removed if that’s not accurate. If you have a hard time fixing this, you can also consider moving this test to |
75d254a
to
74b4cf6
Compare
@addaleax: Moved to known_issues. Ready for merge? |
@ronag This would still need to be reviewed – I didn’t take an in-depth look yet (i.e. I don’t know if the current behaviour might be okay, or how hard it would be to fix this). /cc @nodejs/http2 |
.listen(0, common.mustCall(function() { | ||
const port = server.address().port; | ||
server.once('request', common.mustCall((req, res) => { | ||
assert.ok(!res.finished); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the assertion that fails? Can you please add a comment?
74b4cf6
to
1b4371e
Compare
@mcollina Comments added |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I would prefer that this included a fix, but that's ok too.
Sorry, I tried... it's a bit over my head unfortunately |
|
||
const common = require('../common'); | ||
if (!common.hasCrypto) | ||
common.skip('missing crypto'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mcollina For future reference, what is the purpose of this? I just followed the other tests, not sure if or why it would be needed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ronag The http2
module requires encryption, so if Node.js was compiled without crypto, then http2
tests need to be skipped.
Close in favour of #24339? |
Adds test for #24283. Not actually fixed. Just test.
Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passes