Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: some runtime speed improvements #2429

Closed
wants to merge 3 commits into from
Closed

test: some runtime speed improvements #2429

wants to merge 3 commits into from

Commits on Aug 18, 2015

  1. test: improve test-net-pingpong 

    This includes the following changes:
- a more strict data check rather than a regex
- reduced number of annoying log calls

The most important of the changes is the annoying log calls, which
speeds up the test execution from about 0m1.130s to 0m0.481s on my
machine.
    @brendanashworth
    brendanashworth committed Aug 18, 2015
    Configuration menu
    Copy the full SHA
    21e2cbb View commit details
    Browse the repository at this point in the history

  2. test: improve test-net-server-pause-on-connect 

    Previously the test had a massive timeout (3s!), reduce this to a
platform specific timeout of 50ms.

This test runs two servers at the same time in an attempt to compare
behaviour. I've added a check to make sure one event fires before the
other event, as is expected, but that is a possible race condition.

Improves test run time on my machine from 0m3.141s to 0m0.356s.
    @brendanashworth
    brendanashworth committed Aug 18, 2015
    Configuration menu
    Copy the full SHA
    823233d View commit details
    Browse the repository at this point in the history

  3. test: reduce timeouts in test-net-keepalive 

    Previously 1000-1200ms, they're now (platform dependent) 50-100ms.

Improves test run time on my machine from 0m1.335s to 0m0.236s.
    @brendanashworth
    brendanashworth committed Aug 18, 2015
    Configuration menu
    Copy the full SHA
    7487544 View commit details
    Browse the repository at this point in the history