Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src: fix compiler warning #23954

Closed
wants to merge 1 commit into from
Closed

src: fix compiler warning #23954

wants to merge 1 commit into from

Conversation

cjihrig
Copy link
Contributor

@cjihrig cjihrig commented Oct 29, 2018

The warning is:

../src/util.h:65:11: warning: inline function
'node::Calloc<unsigned char>' is not defined [-Wundefined-inline]
inline T* Calloc(size_t n);
          ^
../src/aliased_buffer.h:41:15: note: used here
    buffer_ = Calloc<NativeT>(count);
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

The warning is:

../src/util.h:65:11: warning: inline function
'node::Calloc<unsigned char>' is not defined [-Wundefined-inline]
inline T* Calloc(size_t n);
          ^
../src/aliased_buffer.h:41:15: note: used here
    buffer_ = Calloc<NativeT>(count);
@nodejs-github-bot nodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label Oct 29, 2018
Copy link
Member

@bnoordhuis bnoordhuis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Duplicate of #23910?


I'll get my coat.

@cjihrig
Copy link
Contributor Author

cjihrig commented Oct 29, 2018

@bnoordhuis oops. Would you rather land 4e10934?

@bnoordhuis
Copy link
Member

Don't worry, it's fine. :-)

@cjihrig
Copy link
Contributor Author

cjihrig commented Oct 29, 2018

@mmarchini mmarchini added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Oct 29, 2018
@joyeecheung
Copy link
Member

Landed in 93335cb

joyeecheung pushed a commit that referenced this pull request Oct 30, 2018
The warning is:

../src/util.h:65:11: warning: inline function
'node::Calloc<unsigned char>' is not defined [-Wundefined-inline]
inline T* Calloc(size_t n);
          ^
../src/aliased_buffer.h:41:15: note: used here
    buffer_ = Calloc<NativeT>(count);

PR-URL: #23954
Reviewed-By: Daniel Bevenius <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Tiancheng "Timothy" Gu <[email protected]>
Reviewed-By: Matheus Marchini <[email protected]>
@richardlau
Copy link
Member

Landed in 93335cb

@joyeecheung Did ncu let this through? It's been open < 48 hours and wasn't fast tracked either.

(Just to be clear, I have no issue with the change itself, just the process.)

@joyeecheung
Copy link
Member

@richardlau oops, my bad, I ignored the warning because I assumed this was fast-tracked

@cjihrig cjihrig deleted the warning branch October 30, 2018 12:53
refack added a commit to refack/node that referenced this pull request Oct 31, 2018
PR-URL: nodejs#23961
Refs: nodejs#23954
Refs: nodejs#23910
Refs: nodejs#23880
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
@targos
Copy link
Member

targos commented Nov 2, 2018

Depends on #23808 to land on v11.x-staging

targos pushed a commit that referenced this pull request Nov 2, 2018
PR-URL: #23961
Refs: #23954
Refs: #23910
Refs: #23880
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
targos pushed a commit that referenced this pull request Nov 18, 2018
The warning is:

../src/util.h:65:11: warning: inline function
'node::Calloc<unsigned char>' is not defined [-Wundefined-inline]
inline T* Calloc(size_t n);
          ^
../src/aliased_buffer.h:41:15: note: used here
    buffer_ = Calloc<NativeT>(count);

PR-URL: #23954
Reviewed-By: Daniel Bevenius <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Tiancheng "Timothy" Gu <[email protected]>
Reviewed-By: Matheus Marchini <[email protected]>
MylesBorins pushed a commit that referenced this pull request Nov 27, 2018
PR-URL: #23961
Refs: #23954
Refs: #23910
Refs: #23880
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
rvagg pushed a commit that referenced this pull request Nov 28, 2018
PR-URL: #23961
Refs: #23954
Refs: #23910
Refs: #23880
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
rvagg pushed a commit that referenced this pull request Nov 28, 2018
The warning is:

../src/util.h:65:11: warning: inline function
'node::Calloc<unsigned char>' is not defined [-Wundefined-inline]
inline T* Calloc(size_t n);
          ^
../src/aliased_buffer.h:41:15: note: used here
    buffer_ = Calloc<NativeT>(count);

PR-URL: #23954
Reviewed-By: Daniel Bevenius <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Tiancheng "Timothy" Gu <[email protected]>
Reviewed-By: Matheus Marchini <[email protected]>
@codebytere
Copy link
Member

Adding the above label as patch application reports:
No changes -- Patch already applied.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++.
Projects
None yet
Development

Successfully merging this pull request may close these issues.