Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

http2: Fix "ERR_HTTP2_INVALID_CONNECTION_HEADERS" error when adding "connection' into header #23908

Closed
wants to merge 22 commits into from
Closed

http2: Fix "ERR_HTTP2_INVALID_CONNECTION_HEADERS" error when adding "connection' into header #23908

wants to merge 22 commits into from

Commits on Dec 14, 2018

  1. lib: http2 compatibility error with connection header 

    Ignoring the connection header and disable the
`ERR_HTTP2_INVALID_CONNECTION_HEADERS` error.

Added a warning log on the compatibility.

Fixes: nodejs#23748
    @sagitsofan
    sagitsofan committed Dec 14, 2018
    Configuration menu
    Copy the full SHA
    685d968 View commit details
    Browse the repository at this point in the history

  2. Update lib/internal/http2/util.js 

    linter fix
    @sagitsofan
    sagitsofan committed Dec 14, 2018
    Configuration menu
    Copy the full SHA
    706d7b0 View commit details
    Browse the repository at this point in the history

  3. spaces remove

    @sagitsofan
    sagitsofan committed Dec 14, 2018
    Configuration menu
    Copy the full SHA
    56a1ef6 View commit details
    Browse the repository at this point in the history

  4. spaces remove

    @sagitsofan
    sagitsofan committed Dec 14, 2018
    Configuration menu
    Copy the full SHA
    8492823 View commit details
    Browse the repository at this point in the history

  5. spaces

    @sagitsofan
    sagitsofan committed Dec 14, 2018
    Configuration menu
    Copy the full SHA
    5287044 View commit details
    Browse the repository at this point in the history

  6. fix linter

    @sagitsofan
    sagitsofan committed Dec 14, 2018
    Configuration menu
    Copy the full SHA
    8c83d2c View commit details
    Browse the repository at this point in the history

  7. move logic into compat.js

    @sagitsofan
    sagitsofan committed Dec 14, 2018
    Configuration menu
    Copy the full SHA
    5c38e7d View commit details
    Browse the repository at this point in the history

  8. change status variable 

    ignore connection header
    @sagitsofan
    sagitsofan committed Dec 14, 2018
    Configuration menu
    Copy the full SHA
    3ef516a View commit details
    Browse the repository at this point in the history

  9. delete internal tests

    @sagitsofan
    sagitsofan committed Dec 14, 2018
    Configuration menu
    Copy the full SHA
    4a3a9b7 View commit details
    Browse the repository at this point in the history

  10. singlequote

    @sagitsofan
    sagitsofan committed Dec 14, 2018
    Configuration menu
    Copy the full SHA
    f158370 View commit details
    Browse the repository at this point in the history

  11. labeling

    @sagitsofan
    sagitsofan committed Dec 14, 2018
    Configuration menu
    Copy the full SHA
    3468c74 View commit details
    Browse the repository at this point in the history

  12. change warning message

    @sagitsofan
    sagitsofan committed Dec 14, 2018
    Configuration menu
    Copy the full SHA
    9173cb1 View commit details
    Browse the repository at this point in the history

  13. change structure 

    check if trailer
    @sagitsofan
    sagitsofan committed Dec 14, 2018
    Configuration menu
    Copy the full SHA
    9bedc32 View commit details
    Browse the repository at this point in the history

  14. change term

    @sagitsofan
    sagitsofan committed Dec 14, 2018
    Configuration menu
    Copy the full SHA
    0ab7481 View commit details
    Browse the repository at this point in the history

  15. remove comment

    @sagitsofan
    sagitsofan committed Dec 14, 2018
    Configuration menu
    Copy the full SHA
    bdf62ce View commit details
    Browse the repository at this point in the history

  16. trailers fix

    @sagitsofan
    sagitsofan committed Dec 14, 2018
    Configuration menu
    Copy the full SHA
    bc1ba7c View commit details
    Browse the repository at this point in the history

  17. only trailers are supported

    @sagitsofan
    sagitsofan committed Dec 14, 2018
    Configuration menu
    Copy the full SHA
    de389eb View commit details
    Browse the repository at this point in the history

  18. c

    @sagitsofan
    sagitsofan committed Dec 14, 2018
    Configuration menu
    Copy the full SHA
    d7fd930 View commit details
    Browse the repository at this point in the history

  19. new line

    @sagitsofan
    sagitsofan committed Dec 14, 2018
    Configuration menu
    Copy the full SHA
    7066aa7 View commit details
    Browse the repository at this point in the history

Commits on Dec 15, 2018

  1. added test for the connection header

    @sagitsofan
    sagitsofan committed Dec 15, 2018
    Configuration menu
    Copy the full SHA
    058a029 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' of https://github.com/nodejs/node into http_compat

    @sagitsofan
    sagitsofan committed Dec 15, 2018
    Configuration menu
    Copy the full SHA
    56f165c View commit details
    Browse the repository at this point in the history

  3. verify warning is emitted

    @sagitsofan
    sagitsofan committed Dec 15, 2018
    Configuration menu
    Copy the full SHA
    0a3cedc View commit details
    Browse the repository at this point in the history