Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: add decode & encode method in querystring.md #23889

Closed
wants to merge 1 commit into from

Conversation

ZYSzys
Copy link
Member

@ZYSzys ZYSzys commented Oct 26, 2018

I found there are querystring.decode method and querystring.encode in the querystring.js but they are not shown on the document. So maybe we need to add these right ?

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. querystring Issues and PRs related to the built-in querystring module. labels Oct 26, 2018
@ZYSzys ZYSzys force-pushed the doc/qs branch 2 times, most recently from df41e02 to 2ea5f03 Compare February 10, 2019 15:58
@ZYSzys
Copy link
Member Author

ZYSzys commented Feb 14, 2019

/cc @nodejs/documentation . Should we add querystring.decode method and querystring.encode into querystring.md ?

doc/api/querystring.md Outdated Show resolved Hide resolved
doc/api/querystring.md Outdated Show resolved Hide resolved
doc/api/querystring.md Outdated Show resolved Hide resolved
doc/api/querystring.md Outdated Show resolved Hide resolved
@joyeecheung
Copy link
Member

I cannot dig up the exact links but I vaguely remember this was brought up once and the decision was to keep the two undocumented, deprecate them, and eventually remove them.

@jasnell @TimothyGu (?)

@vsemozhetbyt
Copy link
Contributor

Is this ready to be landed?

Copy link
Member

@BridgeAR BridgeAR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess it does not hurt to have the alias in place.

@vsemozhetbyt
Copy link
Contributor

@vsemozhetbyt vsemozhetbyt added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 10, 2019
@vsemozhetbyt
Copy link
Contributor

Landed in fb54968
Thank you!

vsemozhetbyt pushed a commit that referenced this pull request Mar 10, 2019
PR-URL: #23889
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
@ZYSzys ZYSzys deleted the doc/qs branch March 10, 2019 15:31
BridgeAR pushed a commit that referenced this pull request Mar 13, 2019
PR-URL: #23889
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
BridgeAR pushed a commit that referenced this pull request Mar 13, 2019
PR-URL: #23889
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
BridgeAR pushed a commit that referenced this pull request Mar 14, 2019
PR-URL: #23889
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
BethGriggs pushed a commit that referenced this pull request Apr 16, 2019
PR-URL: #23889
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
@BethGriggs BethGriggs mentioned this pull request May 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. querystring Issues and PRs related to the built-in querystring module.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants