Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tracing: refactor tracing state ownership #23781

Closed
wants to merge 3 commits into from
Closed

tracing: refactor tracing state ownership #23781

wants to merge 3 commits into from

Commits on Oct 21, 2018

  1. src: remove Environment::tracing_agent_writer() 

    As per the conversation in nodejs#22513,
this is essentially global, and adding this on the Environment
is generally just confusing.

Refs: nodejs#22513
Fixes: nodejs#22767
    @addaleax
    addaleax committed Oct 21, 2018
    Configuration menu
    Copy the full SHA
    afef60e View commit details
    Browse the repository at this point in the history

  2. tracing: forbid tracing modifications from worker threads 

    Forbid modifying tracing state from worker threads, either
through the built-in module or inspector sessions, since
the main thread owns all global state, and at least
the `async_hooks` integration is definitely not thread
safe in its current state.
    @addaleax
    addaleax committed Oct 21, 2018
    Configuration menu
    Copy the full SHA
    443bde0 View commit details
    Browse the repository at this point in the history

  3. squash! tracing: forbid tracing modifications from worker threads

    @addaleax
    addaleax committed Oct 21, 2018
    Configuration menu
    Copy the full SHA
    66094c3 View commit details
    Browse the repository at this point in the history