Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: add Backport-PR-URL info in backport guide #23701

Closed
wants to merge 1 commit into from
Closed

doc: add Backport-PR-URL info in backport guide #23701

wants to merge 1 commit into from

Conversation

ofrobots
Copy link
Contributor

This feedback was raised in #23398 (comment). /cc @targos.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot
Copy link
Collaborator

@ofrobots build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1265/pipeline

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Oct 16, 2018
@vsemozhetbyt vsemozhetbyt mentioned this pull request Oct 16, 2018
Closed
@vsemozhetbyt vsemozhetbyt added the meta Issues and PRs related to the general management of the project. label Oct 16, 2018
targos
targos approved these changes Oct 16, 2018
View reviewed changes
Copy link
Member

@targos targos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I was certain it was already documented somewhere

mmarchini
mmarchini approved these changes Oct 16, 2018
View reviewed changes
Copy link
Contributor

@mmarchini mmarchini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does git node metadata/git node land add Backport-PR-URL to commits?

mhdawson
mhdawson approved these changes Oct 16, 2018
View reviewed changes
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@targos
Copy link
Member

targos commented Oct 16, 2018

@mmarchini No, they do not support landing backport pull requests.

@joyeecheung
Copy link
Member

joyeecheung commented Oct 17, 2018 •
edited
Loading

No, they do not support landing backport pull requests.

Refs: nodejs/node-core-utils#194

(Feeling guilty that this is a 7-month-year-old feature request but PRs are welcomed!)

@ofrobots
Copy link
Contributor Author

CI lite: https://ci.nodejs.org/job/node-test-commit-lite/1207/

@ofrobots ofrobots added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Oct 17, 2018
@Trott
Copy link
Member

Trott commented Oct 19, 2018

It's a total nit, but the commit linter is complaining because the first word after the subsystem is not a lowercase verb. Maybe this for the title line?

doc: add Backport-PR-URL info in backport guide

@ofrobots ofrobots changed the title doc: Backport-PR-URL info in backport guide doc: add Backport-PR-URL info in backport guide Oct 19, 2018
AyushG3112
AyushG3112 reviewed Oct 19, 2018
View reviewed changes
Copy link
Contributor

@AyushG3112 AyushG3112 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

9.1, and all points following this one are now numbered 1

AyushG3112
AyushG3112 reviewed Oct 19, 2018
View reviewed changes
Copy link
Contributor

@AyushG3112 AyushG3112 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixing ordering:

doc/guides/backporting-to-release-lines.md Show resolved Hide resolved
doc/guides/backporting-to-release-lines.md Show resolved Hide resolved
doc/guides/backporting-to-release-lines.md Show resolved Hide resolved
doc/guides/backporting-to-release-lines.md Show resolved Hide resolved
doc/guides/backporting-to-release-lines.md Show resolved Hide resolved
@targos
Copy link
Member

targos commented Oct 19, 2018

@AyushG3112 that's probably done on purpose. It is allowed by markdown and has an advantage: you can add a new line in the middle later without changing the others

@ofrobots
Copy link
Contributor Author

Landed as 72cf81f.

@ofrobots ofrobots closed this Oct 19, 2018
@ofrobots ofrobots deleted the ofrobots-patch-1 branch October 19, 2018 16:00
ofrobots added a commit that referenced this pull request Oct 19, 2018
@ofrobots
doc: add Backport-PR-URL info in backport guide
72cf81f 
PR-URL: #23701
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Matheus Marchini <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Shelley Vohr <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Sakthipriyan Vairamani <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: George Adams <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
addaleax pushed a commit that referenced this pull request Oct 20, 2018
@ofrobots @addaleax
doc: add Backport-PR-URL info in backport guide
111018c 
PR-URL: #23701
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Matheus Marchini <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Shelley Vohr <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Sakthipriyan Vairamani <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: George Adams <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
jasnell pushed a commit that referenced this pull request Oct 21, 2018
@ofrobots @jasnell
doc: add Backport-PR-URL info in backport guide
4c7f16d 
PR-URL: #23701
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Matheus Marchini <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Shelley Vohr <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Sakthipriyan Vairamani <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: George Adams <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
MylesBorins pushed a commit that referenced this pull request Oct 30, 2018
@ofrobots @MylesBorins
doc: add Backport-PR-URL info in backport guide
d862f1e 
PR-URL: #23701
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Matheus Marchini <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Shelley Vohr <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Sakthipriyan Vairamani <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: George Adams <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
@codebytere codebytere mentioned this pull request Nov 27, 2018
Closed
rvagg pushed a commit that referenced this pull request Nov 28, 2018
@ofrobots @rvagg
doc: add Backport-PR-URL info in backport guide
cdc353d 
PR-URL: #23701
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Matheus Marchini <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Shelley Vohr <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Sakthipriyan Vairamani <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: George Adams <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
MylesBorins pushed a commit that referenced this pull request Nov 29, 2018
@ofrobots @MylesBorins
doc: add Backport-PR-URL info in backport guide
e85d15a 
PR-URL: #23701
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Matheus Marchini <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Shelley Vohr <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Sakthipriyan Vairamani <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: George Adams <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
@codebytere codebytere mentioned this pull request Nov 29, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vsemozhetbyt vsemozhetbyt vsemozhetbyt left review comments

@AyushG3112 AyushG3112 AyushG3112 left review comments

@gdams gdams gdams approved these changes

@trivikr trivikr trivikr approved these changes

@mhdawson mhdawson mhdawson approved these changes

@joyeecheung joyeecheung joyeecheung approved these changes

@refack refack refack approved these changes

@targos targos targos approved these changes

@codebytere codebytere codebytere approved these changes

@lpinca lpinca lpinca approved these changes

@thefourtheye thefourtheye thefourtheye approved these changes

@jasnell jasnell jasnell approved these changes

@mmarchini mmarchini mmarchini approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. meta Issues and PRs related to the general management of the project.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.