Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: fix ./configure --enable-d8 #23656

Closed
wants to merge 1 commit into from

Conversation

bnoordhuis
Copy link
Member

Add SHARED_INTERMEDIATE_DIR to the include path because that is where
Torque-generated files live. d8.cc includes files from deps/v8/src
that depend on those generated files.

Add SHARED_INTERMEDIATE_DIR to the include path because that is where
Torque-generated files live. d8.cc includes files from deps/v8/src
that depend on those generated files.
@nodejs-github-bot nodejs-github-bot added the v8 engine Issues and PRs related to the V8 dependency. label Oct 14, 2018
@danbev
Copy link
Contributor

danbev commented Oct 18, 2018

@danbev
Copy link
Contributor

danbev commented Oct 18, 2018

Landed in 05394d2.

@danbev danbev closed this Oct 18, 2018
danbev pushed a commit that referenced this pull request Oct 18, 2018
Add SHARED_INTERMEDIATE_DIR to the include path because that is where
Torque-generated files live. d8.cc includes files from deps/v8/src
that depend on those generated files.

PR-URL: #23656
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Gus Caplan <[email protected]>
addaleax pushed a commit that referenced this pull request Oct 20, 2018
Add SHARED_INTERMEDIATE_DIR to the include path because that is where
Torque-generated files live. d8.cc includes files from deps/v8/src
that depend on those generated files.

PR-URL: #23656
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Gus Caplan <[email protected]>
jasnell pushed a commit that referenced this pull request Oct 21, 2018
Add SHARED_INTERMEDIATE_DIR to the include path because that is where
Torque-generated files live. d8.cc includes files from deps/v8/src
that depend on those generated files.

PR-URL: #23656
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Gus Caplan <[email protected]>
MylesBorins pushed a commit that referenced this pull request Oct 30, 2018
Add SHARED_INTERMEDIATE_DIR to the include path because that is where
Torque-generated files live. d8.cc includes files from deps/v8/src
that depend on those generated files.

PR-URL: #23656
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Gus Caplan <[email protected]>
@codebytere codebytere mentioned this pull request Nov 27, 2018
rvagg pushed a commit that referenced this pull request Nov 28, 2018
Add SHARED_INTERMEDIATE_DIR to the include path because that is where
Torque-generated files live. d8.cc includes files from deps/v8/src
that depend on those generated files.

PR-URL: #23656
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Gus Caplan <[email protected]>
MylesBorins pushed a commit that referenced this pull request Nov 29, 2018
Add SHARED_INTERMEDIATE_DIR to the include path because that is where
Torque-generated files live. d8.cc includes files from deps/v8/src
that depend on those generated files.

PR-URL: #23656
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Gus Caplan <[email protected]>
@codebytere codebytere mentioned this pull request Nov 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v8 engine Issues and PRs related to the V8 dependency.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants