Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: add test coverage for fs.truncate #23620

Merged
merged 1 commit into from
Oct 15, 2018
Merged

test: add test coverage for fs.truncate #23620

merged 1 commit into from
Oct 15, 2018

Commits on Oct 15, 2018

  1. test: add test coverage for fs.truncate 

    Add test to check:
- for `null` as len parameter
- if error is propagated into callback if file doesn't exist
- if an error is actually thrown if len is not a number

PR-URL: nodejs#23620
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Sakthipriyan Vairamani <[email protected]>
Reviewed-By: Denys Otrishko <[email protected]>
    @christian-bromann @refack
    christian-bromann authored and refack committed Oct 15, 2018
    Configuration menu
    Copy the full SHA
    74f854e View commit details
    Browse the repository at this point in the history