Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: add logging to test-worker-memory #23418

Closed
wants to merge 1 commit into from
Closed

test: add logging to test-worker-memory #23418

wants to merge 1 commit into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Oct 11, 2018

To help troubleshoot CI failures, add some logging.

Refs: #23277 (comment)

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@Trott
test: add logging to test-worker-memory
d60de05 
To help troubleshoot CI failures, add some logging.

Refs: nodejs#23277 (comment)
@nodejs-github-bot
Copy link
Collaborator

@Trott build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1199/pipeline

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Oct 11, 2018
@Trott Trott mentioned this pull request Oct 11, 2018
Closed
@Trott
Copy link
Member Author

Trott commented Oct 11, 2018

@addaleax If you think this might help troubleshoot, let's fast-track and land. (👍 here to fast-track.)

If you don't think it will be helpful, feel free to close.

@Trott Trott added the fast-track PRs that do not need to wait for 48 hours to land. label Oct 11, 2018
@Trott
Copy link
Member Author

Trott commented Oct 11, 2018

CI: https://ci.nodejs.org/job/node-test-pull-request/17739/

addaleax
addaleax approved these changes Oct 11, 2018
View reviewed changes
Copy link
Member

@addaleax addaleax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It definitely can’t hurt :)

@addaleax addaleax added the worker Issues and PRs related to Worker support. label Oct 11, 2018
@Trott
Copy link
Member Author

Trott commented Oct 11, 2018

Resume Build: https://ci.nodejs.org/job/node-test-pull-request/17742/

@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Oct 11, 2018
@Trott
Copy link
Member Author

Trott commented Oct 11, 2018

Landed in f121ac0

@Trott Trott closed this Oct 11, 2018
Trott added a commit to Trott/io.js that referenced this pull request Oct 11, 2018
@Trott
test: add logging to test-worker-memory
f121ac0 
To help troubleshoot CI failures, add some logging.

Refs: nodejs#23277 (comment)

PR-URL: nodejs#23418
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Sakthipriyan Vairamani <[email protected]>
targos pushed a commit that referenced this pull request Oct 12, 2018
@Trott @targos
test: add logging to test-worker-memory
b279b96 
To help troubleshoot CI failures, add some logging.

Refs: #23277 (comment)

PR-URL: #23418
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Sakthipriyan Vairamani <[email protected]>
jasnell pushed a commit that referenced this pull request Oct 17, 2018
@Trott @jasnell
test: add logging to test-worker-memory
0fa857f 
To help troubleshoot CI failures, add some logging.

Refs: #23277 (comment)

PR-URL: #23418
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Sakthipriyan Vairamani <[email protected]>
MylesBorins pushed a commit that referenced this pull request Oct 30, 2018
@Trott @MylesBorins
test: add logging to test-worker-memory
27dd4de 
To help troubleshoot CI failures, add some logging.

Refs: #23277 (comment)

PR-URL: #23418
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Sakthipriyan Vairamani <[email protected]>
@codebytere codebytere mentioned this pull request Nov 27, 2018
Closed
rvagg pushed a commit that referenced this pull request Nov 28, 2018
@Trott @rvagg
test: add logging to test-worker-memory
3781bab 
To help troubleshoot CI failures, add some logging.

Refs: #23277 (comment)

PR-URL: #23418
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Sakthipriyan Vairamani <[email protected]>
MylesBorins pushed a commit that referenced this pull request Nov 29, 2018
@Trott @MylesBorins
test: add logging to test-worker-memory
ad47ae7 
To help troubleshoot CI failures, add some logging.

Refs: #23277 (comment)

PR-URL: #23418
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Sakthipriyan Vairamani <[email protected]>
@codebytere codebytere mentioned this pull request Nov 29, 2018
Merged
@Trott Trott deleted the minimal-logging branch January 13, 2022 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes

@addaleax addaleax addaleax approved these changes

@thefourtheye thefourtheye thefourtheye approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. fast-track PRs that do not need to wait for 48 hours to land. test Issues and PRs related to the tests. worker Issues and PRs related to Worker support.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Trott @nodejs-github-bot @thefourtheye @addaleax @gireeshpunathil