deps: cherry-pick V8 changes to extend hash seed to 64-bit #23264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
build
2 tasks
addaleax
approved these changes
Oct 4, 2018
ofrobots
approved these changes
Oct 4, 2018
mohammed-adil-moughal
approved these changes
Oct 5, 2018
This serves as mitigation for the so-called HashWick vulnerability.
Original commit messages:
commit 3833fef57368c53c6170559ffa524c8c69f16ee5
Author: Yang Guo <[email protected]>
Date: Thu Sep 20 11:43:13 2018
Refactor integer hashing function names
We now clearly differentiate between:
- unseeded hash for 32-bit integers
- unseeded hash for 64-bit integers
- seeded hash for 32-bit integers
- seeded hash for strings
[email protected]
Bug: chromium:680662
Change-Id: I7459958c4158ee3501c962943dff8f33258bb5ce
Reviewed-on: https://chromium-review.googlesource.com/1235973
Commit-Queue: Yang Guo <[email protected]>
Reviewed-by: Benedikt Meurer <[email protected]>
Cr-Commit-Position: refs/heads/master@{#56068}
commit 95a979e02d7154e45b293261a6998c99d71fc238
Author: Yang Guo <[email protected]>
Date: Thu Sep 20 14:34:48 2018
Call into C++ to compute seeded integer hash
[email protected]
Bug: chromium:680662
Change-Id: I8dace89d576dfcc5833fd539ce698a9ade1cb5a0
Reviewed-on: https://chromium-review.googlesource.com/1235928
Commit-Queue: Yang Guo <[email protected]>
Reviewed-by: Benedikt Meurer <[email protected]>
Cr-Commit-Position: refs/heads/master@{#56091}
commit 2c2af0022d5feb9e525a00a76cb15db9f3e38dba
Author: Yang Guo <[email protected]>
Date: Thu Sep 27 16:37:57 2018
Use 64-bit for seeded integer hashes
[email protected]
Bug: chromium:680662
Change-Id: If48d1043dbe1e1bb695ec890c23e103a6cacf2d4
Reviewed-on: https://chromium-review.googlesource.com/1244220
Commit-Queue: Yang Guo <[email protected]>
Reviewed-by: Peter Marshall <[email protected]>
Cr-Commit-Position: refs/heads/master@{#56271}
Refs: nodejs#23259
hashseed
force-pushed
the
64bithash_on_master
branch
from
33eff96
to
c971fd4
Compare
jasnell
approved these changes
Oct 5, 2018
|
Landed as 314c1fa |
hashseed
added a commit
that referenced
this pull request
Oct 8, 2018
This serves as mitigation for the so-called HashWick vulnerability.
Original commit messages:
commit 3833fef57368c53c6170559ffa524c8c69f16ee5
Author: Yang Guo <[email protected]>
Date: Thu Sep 20 11:43:13 2018
Refactor integer hashing function names
We now clearly differentiate between:
- unseeded hash for 32-bit integers
- unseeded hash for 64-bit integers
- seeded hash for 32-bit integers
- seeded hash for strings
[email protected]
Bug: chromium:680662
Change-Id: I7459958c4158ee3501c962943dff8f33258bb5ce
Reviewed-on: https://chromium-review.googlesource.com/1235973
Commit-Queue: Yang Guo <[email protected]>
Reviewed-by: Benedikt Meurer <[email protected]>
Cr-Commit-Position: refs/heads/master@{#56068}
commit 95a979e02d7154e45b293261a6998c99d71fc238
Author: Yang Guo <[email protected]>
Date: Thu Sep 20 14:34:48 2018
Call into C++ to compute seeded integer hash
[email protected]
Bug: chromium:680662
Change-Id: I8dace89d576dfcc5833fd539ce698a9ade1cb5a0
Reviewed-on: https://chromium-review.googlesource.com/1235928
Commit-Queue: Yang Guo <[email protected]>
Reviewed-by: Benedikt Meurer <[email protected]>
Cr-Commit-Position: refs/heads/master@{#56091}
commit 2c2af0022d5feb9e525a00a76cb15db9f3e38dba
Author: Yang Guo <[email protected]>
Date: Thu Sep 27 16:37:57 2018
Use 64-bit for seeded integer hashes
[email protected]
Bug: chromium:680662
Change-Id: If48d1043dbe1e1bb695ec890c23e103a6cacf2d4
Reviewed-on: https://chromium-review.googlesource.com/1244220
Commit-Queue: Yang Guo <[email protected]>
Reviewed-by: Peter Marshall <[email protected]>
Cr-Commit-Position: refs/heads/master@{#56271}
Refs: #23259
PR-URL: #23264
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Ali Ijaz Sheikh <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
jasnell
pushed a commit
that referenced
this pull request
Oct 17, 2018
This serves as mitigation for the so-called HashWick vulnerability.
Original commit messages:
commit 3833fef57368c53c6170559ffa524c8c69f16ee5
Author: Yang Guo <[email protected]>
Date: Thu Sep 20 11:43:13 2018
Refactor integer hashing function names
We now clearly differentiate between:
- unseeded hash for 32-bit integers
- unseeded hash for 64-bit integers
- seeded hash for 32-bit integers
- seeded hash for strings
[email protected]
Bug: chromium:680662
Change-Id: I7459958c4158ee3501c962943dff8f33258bb5ce
Reviewed-on: https://chromium-review.googlesource.com/1235973
Commit-Queue: Yang Guo <[email protected]>
Reviewed-by: Benedikt Meurer <[email protected]>
Cr-Commit-Position: refs/heads/master@{#56068}
commit 95a979e02d7154e45b293261a6998c99d71fc238
Author: Yang Guo <[email protected]>
Date: Thu Sep 20 14:34:48 2018
Call into C++ to compute seeded integer hash
[email protected]
Bug: chromium:680662
Change-Id: I8dace89d576dfcc5833fd539ce698a9ade1cb5a0
Reviewed-on: https://chromium-review.googlesource.com/1235928
Commit-Queue: Yang Guo <[email protected]>
Reviewed-by: Benedikt Meurer <[email protected]>
Cr-Commit-Position: refs/heads/master@{#56091}
commit 2c2af0022d5feb9e525a00a76cb15db9f3e38dba
Author: Yang Guo <[email protected]>
Date: Thu Sep 27 16:37:57 2018
Use 64-bit for seeded integer hashes
[email protected]
Bug: chromium:680662
Change-Id: If48d1043dbe1e1bb695ec890c23e103a6cacf2d4
Reviewed-on: https://chromium-review.googlesource.com/1244220
Commit-Queue: Yang Guo <[email protected]>
Reviewed-by: Peter Marshall <[email protected]>
Cr-Commit-Position: refs/heads/master@{#56271}
Refs: #23259
PR-URL: #23264
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Ali Ijaz Sheikh <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This serves as mitigation for the so-called HashWick vulnerability.
Original commit messages:
Refs: #23259
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes