src: ready background workers before bootstrap #23233
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
the
c++
jasnell
approved these changes
Oct 3, 2018
bnoordhuis
reviewed
Oct 3, 2018
Make sure background workers are ready before proceeding with the bootstrap or post-bootstrap execution of any code that may trigger `process.exit()`. Fixes: nodejs#23065
ofrobots
force-pushed
the
fix-windows-background-worker-init-mutex
branch
from
de3e607
to
3afca3a
Compare
|
Switched to C++ mutex classes. This needs another look. New CI: https://ci.nodejs.org/job/node-test-pull-request/17601/ |
2 tasks
|
Relaunched SmartOS: https://ci.nodejs.org/job/node-test-commit-smartos/20672/ |
|
SmartOS failures are in |
addaleax
reviewed
Oct 3, 2018
|
Re-run of arm-fanned, as there seemed to be unrelated failures: https://ci.nodejs.org/job/node-test-commit-arm-fanned/3841/ |
addaleax
approved these changes
Oct 4, 2018
|
Is there any chance test-stream-buffer-list failing on all three Pi variants is remotely related? 21:30:07 not ok 228 parallel/test-stream-buffer-list
21:30:07 ---
21:30:07 duration_ms: 1.35
21:30:07 severity: fail
21:30:07 exitcode: 1
21:30:07 stack: |-
21:30:07 assert.js:84
21:30:07 throw new AssertionError(obj);
21:30:07 ^
21:30:07
21:30:07 AssertionError [ERR_ASSERTION]: Expected values to be strictly equal:
21:30:07 + actual - expected
21:30:07
21:30:07 + �[32m'BufferList { head: \u001b[1mnull\u001b[22m, tail: \u001b[1mnull\u001b[22m, length: \u001b[33m0\u001b[39m }'�[39m
21:30:07 - �[32m'BufferList { length: \u001b[33m0\u001b[39m }'�[39m
21:30:07 at Object.<anonymous> (/home/iojs/build/workspace/node-test-binary-arm/test/parallel/test-stream-buffer-list.js:37:8)
21:30:07 at Module._compile (internal/modules/cjs/loader.js:703:30)
21:30:07 at Object.Module._extensions..js (internal/modules/cjs/loader.js:714:10)
21:30:07 at Module.load (internal/modules/cjs/loader.js:613:32)
21:30:07 at tryModuleLoad (internal/modules/cjs/loader.js:552:12)
21:30:07 at Function.Module._load (internal/modules/cjs/loader.js:544:3)
21:30:07 at Function.Module.runMain (internal/modules/cjs/loader.js:756:12)
21:30:07 at startup (internal/bootstrap/node.js:303:19)
21:30:07 at bootstrapNodeJSCore (internal/bootstrap/node.js:865:3)
21:30:07 ... |
|
^^^^^ Guessing not since it didn't fail the first time? Let's try a rebuild again... |
|
Yikes, infra that last time. Trying again: https://ci.nodejs.org/job/node-test-commit-arm-fanned/3869/ |
|
I see the problem. The rebuilds don't rebase unless you tell them what commit to rebase onto, so they don't have a fix for that one test from a few days ago. Here's a rebuild with a rebase on current master: https://ci.nodejs.org/job/node-test-commit-arm-fanned/3870/ |
|
Landed in e273abc |
Trott
pushed a commit
to Trott/io.js
that referenced
this pull request
Oct 6, 2018
Make sure background workers are ready before proceeding with the bootstrap or post-bootstrap execution of any code that may trigger `process.exit()`. Fixes: nodejs#23065 PR-URL: nodejs#23233 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
|
Should this be backported to |
|
v10.x backport: #23398 |
ofrobots
added a commit
to ofrobots/node
that referenced
this pull request
Oct 13, 2018
Make sure background workers are ready before proceeding with the bootstrap or post-bootstrap execution of any code that may trigger `process.exit()`. Fixes: nodejs#23065 PR-URL: nodejs#23233 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
ofrobots
added a commit
that referenced
this pull request
Oct 15, 2018
Make sure background workers are ready before proceeding with the bootstrap or post-bootstrap execution of any code that may trigger `process.exit()`. Fixes: #23065 PR-URL: #23233 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
jasnell
pushed a commit
that referenced
this pull request
Oct 17, 2018
Make sure background workers are ready before proceeding with the bootstrap or post-bootstrap execution of any code that may trigger `process.exit()`. Fixes: #23065 PR-URL: #23233 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Oct 30, 2018
Make sure background workers are ready before proceeding with the bootstrap or post-bootstrap execution of any code that may trigger `process.exit()`. Fixes: #23065 PR-URL: #23233 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
Closed
rvagg
pushed a commit
that referenced
this pull request
Nov 28, 2018
Make sure background workers are ready before proceeding with the bootstrap or post-bootstrap execution of any code that may trigger `process.exit()`. Fixes: #23065 PR-URL: #23233 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Nov 29, 2018
Make sure background workers are ready before proceeding with the bootstrap or post-bootstrap execution of any code that may trigger `process.exit()`. Fixes: #23065 PR-URL: #23233 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
Merged
addaleax
added
the
v8 platform
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an alternative to #23110 that doesn't depend upon libuv/libuv#2003.
Make sure background workers are ready before proceeding with the
bootstrap or post-bootstrap execution of any code that may trigger
process.exit().Fixes: #23065
EDIT: CI: https://ci.nodejs.org/job/node-test-pull-request/17595/
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes