test: replace localhost with os.hostname in fs-readfilesync #23101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you confirm that the test still works with this change if the host is disconnected from the network? |
|
(Actually, if you could confirm that it works in its current form on the master branch when disconnected from the network, that would be helpful too!) |
|
@Trott, sorry for the delay. I have run this test with/without network successfully both on master and on this branch. Edit: I ran them on Windows 10 (10.0.17134 Build 17134), just to clarify. |
|
This is a Windows-only test, I believe, so... @nodejs/platform-windows Can one or two folks review? @nodejs/testing too... |
addaleax
approved these changes
Sep 30, 2018
addaleax
added
author ready
|
Landed in 1be804d. |
danbev
pushed a commit
that referenced
this pull request
Oct 1, 2018
PR-URL: #23101 Fixes: #21501 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: John-David Dalton <[email protected]>
targos
pushed a commit
that referenced
this pull request
Oct 1, 2018
PR-URL: #23101 Fixes: #21501 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: John-David Dalton <[email protected]>
targos
pushed a commit
that referenced
this pull request
Oct 3, 2018
PR-URL: #23101 Fixes: #21501 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: John-David Dalton <[email protected]>
This was referenced Oct 10, 2018
This was referenced Oct 11, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #21501
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes (waiting for CI)@targos could you please try this on the setup mentioned in the issue if possible?