Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lib: lazy load internal/queue_microtask #23046

Merged
merged 1 commit into from
Sep 24, 2018
Merged

lib: lazy load internal/queue_microtask #23046

merged 1 commit into from
Sep 24, 2018

Conversation

devsnek
Copy link
Member

@devsnek devsnek commented Sep 24, 2018

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot
Copy link
Collaborator

@devsnek build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/988/pipeline

@devsnek
Copy link
Member Author

devsnek commented Sep 24, 2018

CI https://ci.nodejs.org/job/node-test-pull-request/17398/

Trott
Trott approved these changes Sep 24, 2018
View reviewed changes
Copy link
Member

@Trott Trott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if CI is green/yellow

@Trott Trott added the fast-track PRs that do not need to wait for 48 hours to land. label Sep 24, 2018
@Trott
Copy link
Member

Trott commented Sep 24, 2018 •
edited by devsnek
Loading

This is to unbreak CI. Please 👍 here to fast-track.

@Trott Trott mentioned this pull request Sep 24, 2018
Merged
3 tasks
@devsnek
lib: lazy load internal/queue_microtask
ea8000f 
PR-URL: nodejs#23046
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: John-David Dalton <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
@devsnek devsnek closed this Sep 24, 2018
@devsnek devsnek merged commit ea8000f into nodejs:master Sep 24, 2018
@devsnek devsnek deleted the tears branch September 24, 2018 05:09
@joyeecheung joyeecheung mentioned this pull request Sep 26, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes

@cjihrig cjihrig cjihrig approved these changes

@Trott Trott Trott approved these changes

@jdalton jdalton jdalton approved these changes

Assignees
No one assigned
Labels
fast-track PRs that do not need to wait for 48 hours to land.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@devsnek @nodejs-github-bot @Trott @jdalton @cjihrig @gireeshpunathil @targos