tools, test: forbid string literal as third argument for assert.strictEqual() and friends #22849
Commits on Sep 13, 2018
-
test: remove string literal message from assertion
Remove string literal message in assert.strictEqual() call in napi test testFinalizer.js.
-
test: remove string literal message in assertions
Remove string literal message in assert.strictEqual() calls in test-async-await.js.
-
test: improve assertion in test-inspector.js
Remove an unecessary string literal from assert.strictEqual() call in test-inspector.js. The string literal is printed instead of the value that causes an error. Removing the string literal allows the value that caused the error to be printed. This improves the troubleshooting experience when the test fails due to that assertion.
-
test: simplify assertion in http2 tests
In test-http2-timeout-large-write.js and test-http2-timeout-large-write-file.js: Use assert.ok() on a boolean that the test itself creates and sets, rather than assert.strictEqual(). This allows us to use a static message without running afoul of the upcoming "do not use string literals with assert.strictEqual()" lint rule.
-
Refactor test-vm-run-in-new-context so that check for `--expose-gc` flag will not run afoul of an upcoming lint rule that checks that string literals are not used for the `message` argument of `assert.strictEqual()`.
-
test: remove string literal from assertion
Remove string literal from `assert.strictEqual()` call `message` parameter and make it a comment above the assertion instead.
-
test: remove string literal message from assertion
Remove string literal from assert.strictEqual message to improve output of AssertionError.
-
test: remove string literal arg from assertion
Remove unnecessary string literal from assert.deepStrictEqual() call.
-
test: remove string literal from assertion
Remove string literal as assertion message in call to assert.strictEqual() in test-dns-resolveany-bad-ancount.
-
test: remove string literal from assertion
Remove string literal as assertion message in call to assert.strictEqual() in test-dns-lookup.
-
test: prepare test-assert for strictEqual linting
Make minor modifications to test-assert.js to prepare it for linting rule that forbids the use of string literals for the third argument of assert.strictEqual().
-
tools: prevent string literals in some assertions
String literals provided as the third argument to assert.strictEqual() or assert.deepStrictEqual() will mask the values that are causing issues. Use a lint rule to prevent such usage.
