tools,doc: apilinks should handle root scenarios #22721
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
doc
rubys
approved these changes
Sep 6, 2018
tools/doc/apilinks.js
Outdated
| @@ -67,6 +69,7 @@ process.argv.slice(2).forEach((file) => { | |||
| if (expr.type !== 'AssignmentExpression') return; | |||
|
|
|||
| let lhs = expr.left; | |||
| if (expr.left.type !== 'MemberExpression') return; | |||
There was a problem hiding this comment.
Nit: should probably be lhs.type (and yes, that applies to the line below too).
There was a problem hiding this comment.
Thanks! While doing this I noticed the redundant check and removed it. The logic should be that we only look for the object in cases where it's already a MemberExpression and only replace it in cases where the object is also MemberExpression. I compared the output with and without my changes and it's identical, so I think this logic is sound.
jasnell
approved these changes
Sep 6, 2018
4 tasks
kfarnung
changed the title
4 tasks
|
Looks like #22706 should replace part of my fix, I've rebased and I'm retesting locally before pushing. |
|
Rebased and passing tests. |
|
Landed in 3bdc61d |
targos
pushed a commit
that referenced
this pull request
Sep 10, 2018
* Prevent crash when setting root properties * Allow return outside of function PR-URL: #22721 Reviewed-By: Sam Ruby <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Node-ChakraCore we ran into some issues with this script. Rather than fix them downstream I think the fixes are potentially valuable here.
Root properties example: https://github.com/nodejs/node-chakracore/blob/a3d02b2794fa7fdf03be48d3b4a8cd87b7345402/lib/trace_mgr.js#L618
Return outside of function example: https://github.com/nodejs/node-chakracore/blob/a3d02b2794fa7fdf03be48d3b4a8cd87b7345402/lib/v8.js#L17-L19
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes