zlib: fix memory leak for invalid input #22713
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Don’t toggle the weak/strong reference flag from the error handler, that’s too confusing. Instead, always do it in the code that handles the write call. Fixes: nodejs#22705
nodejs-github-bot
added
c++
jasnell
approved these changes
Sep 5, 2018
|
Why did Travis fail but the other checks show as passing? Is the test flaky or are the checks not reporting the correct status? |
|
@mscdex Flakyness, yes – should be fixed now. :) CI: https://ci.nodejs.org/job/node-test-pull-request/17037/ I’d like to fast-track this, since it’s not a complex fix and it would be good to have this in 10.10.0 (fyi @targos). Please 👍 if you agree. |
|
New CI: https://ci.nodejs.org/job/node-test-pull-request/17040/ (:heavy_check_mark:) |
|
Landed in 0c30d0e |
addaleax
added a commit
that referenced
this pull request
Sep 6, 2018
Don’t toggle the weak/strong reference flag from the error handler, that’s too confusing. Instead, always do it in the code that handles the write call. Fixes: #22705 PR-URL: #22713 Reviewed-By: James M Snell <[email protected]>
targos
pushed a commit
that referenced
this pull request
Sep 6, 2018
Don’t toggle the weak/strong reference flag from the error handler, that’s too confusing. Instead, always do it in the code that handles the write call. Fixes: #22705 PR-URL: #22713 Reviewed-By: James M Snell <[email protected]>
This was referenced Sep 6, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don’t toggle the weak/strong reference flag from the error
handler, that’s too confusing. Instead, always do it in the
code that handles the write call.
Fixes: #22705
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes