Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: remove editing leftovers from options help text #22636

Closed
wants to merge 1 commit into from
Closed

src: remove editing leftovers from options help text #22636

wants to merge 1 commit into from

Conversation

addaleax
Copy link
Member

Refs: 85212bb#r30265305

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot
Copy link
Collaborator

@addaleax build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/755/pipeline

@nodejs-github-bot nodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label Aug 31, 2018
@BridgeAR BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Sep 1, 2018
@BridgeAR
Copy link
Member

BridgeAR commented Sep 1, 2018 •
edited by addaleax
Loading

CI https://ci.nodejs.org/job/node-test-pull-request/16918/ (:heavy_check_mark:)

This was referenced Sep 4, 2018
Closed
Closed
@danbev
Copy link
Contributor

danbev commented Sep 5, 2018

Landed in 65f0323.

@danbev danbev closed this Sep 5, 2018
danbev pushed a commit that referenced this pull request Sep 5, 2018
@addaleax @danbev
src: remove editing leftovers from options help text
65f0323 
PR-URL: #22636
Refs: https://github.com/nodejs/node/commit/
85212bb#r30265305
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
@addaleax addaleax deleted the remove-2u branch September 5, 2018 09:24
targos pushed a commit that referenced this pull request Sep 5, 2018
@addaleax @targos
src: remove editing leftovers from options help text
dbb8f37 
PR-URL: #22636
Refs: https://github.com/nodejs/node/commit/
85212bb#r30265305
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
@targos targos mentioned this pull request Sep 5, 2018
Merged
targos pushed a commit that referenced this pull request Sep 6, 2018
@addaleax @targos
src: remove editing leftovers from options help text
3d6d137 
PR-URL: #22636
Refs: https://github.com/nodejs/node/commit/
85212bb#r30265305
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
This was referenced Sep 6, 2018
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@lpinca lpinca lpinca approved these changes

@cjihrig cjihrig cjihrig approved these changes

@richardlau richardlau richardlau approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

@trivikr trivikr trivikr approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@addaleax @nodejs-github-bot @BridgeAR @danbev @jasnell @lpinca @cjihrig @richardlau @trivikr