win, build: remove superfluous error message #22580
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When building from clean checkout, `vcbuild` will produce superfluous error message about missing .tmp_gyp_configure_stamp and .gyp_configure_stamp. This removes both those messages.
nodejs-github-bot
added
build
|
@nodejs/platform-windows @nodejs/build-files PTAL |
refack
approved these changes
Aug 31, 2018
|
@bzoz I'm kind of on a "add more comments" kick, so could you add comments as to why it's Ok to swallow the errors? |
|
Landed in 86dc0ba |
addaleax
pushed a commit
that referenced
this pull request
Sep 2, 2018
When building from clean checkout, `vcbuild` will produce superfluous error message about missing .tmp_gyp_configure_stamp and .gyp_configure_stamp. This removes both those messages. PR-URL: #22580 Reviewed-By: Refael Ackermann <[email protected]>
targos
pushed a commit
that referenced
this pull request
Sep 2, 2018
When building from clean checkout, `vcbuild` will produce superfluous error message about missing .tmp_gyp_configure_stamp and .gyp_configure_stamp. This removes both those messages. PR-URL: #22580 Reviewed-By: Refael Ackermann <[email protected]>
targos
pushed a commit
that referenced
this pull request
Sep 3, 2018
When building from clean checkout, `vcbuild` will produce superfluous error message about missing .tmp_gyp_configure_stamp and .gyp_configure_stamp. This removes both those messages. PR-URL: #22580 Reviewed-By: Refael Ackermann <[email protected]>
targos
pushed a commit
that referenced
this pull request
Sep 6, 2018
When building from clean checkout, `vcbuild` will produce superfluous error message about missing .tmp_gyp_configure_stamp and .gyp_configure_stamp. This removes both those messages. PR-URL: #22580 Reviewed-By: Refael Ackermann <[email protected]>
This was referenced Sep 6, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When building from clean checkout,
vcbuildwill produce superfluous error message about missing.tmp_gyp_configure_stampand.gyp_configure_stamp:This removes both those messages.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes