Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tools: specify ESLint rules being disabled in two files #22563

Closed
wants to merge 2 commits into from
Closed

tools: specify ESLint rules being disabled in two files #22563

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
91727d3
tools: specify rules disabled in common/dns.js
Trott Aug 28, 2018
26af2e5
tools: specify rule disabled in test-assert.js
Trott Aug 28, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion test/common/dns.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ function readDomainFromPacket(buffer, offset) {
} else {
// Pointer to another part of the packet.
assert.strictEqual(length & 0xC0, 0xC0);
// eslint-disable-next-line
// eslint-disable-next-line space-infix-ops, space-unary-ops
const pointeeOffset = buffer.readUInt16BE(offset) &~ 0xC000;
return {
nread: 2,
Expand Down
8 changes: 4 additions & 4 deletions test/parallel/test-assert.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -692,7 +692,7 @@ common.expectsError(
() => {
a(
(() => 'string')()
// eslint-disable-next-line
// eslint-disable-next-line operator-linebreak
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI is failing because the message check in L701-L712 needs to be updated to match.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Argh! Fixed.

===
123 instanceof
Buffer
Expand All @@ -704,7 +704,7 @@ common.expectsError(
message: 'The expression evaluated to a falsy value:\n\n' +
' a(\n' +
' (() => \'string\')()\n' +
' // eslint-disable-next-line\n' +
' // eslint-disable-next-line operator-linebreak\n' +
' ===\n' +
' 123 instanceof\n' +
' Buffer\n' +
Expand All @@ -716,7 +716,7 @@ common.expectsError(
() => {
a(
(() => 'string')()
// eslint-disable-next-line
// eslint-disable-next-line operator-linebreak
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI is failing because the message check in L725-L736 needs to be updated to match.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also: Argh! Fixed.

===
123 instanceof
Buffer
Expand All @@ -728,7 +728,7 @@ common.expectsError(
message: 'The expression evaluated to a falsy value:\n\n' +
' a(\n' +
' (() => \'string\')()\n' +
' // eslint-disable-next-line\n' +
' // eslint-disable-next-line operator-linebreak\n' +
' ===\n' +
' 123 instanceof\n' +
' Buffer\n' +
Expand Down