test: move common.isCPPSymbolsNotMapped to tick-processor tests #22459
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasnell
force-pushed
the
test-move-common-tickprocessor
branch
from
9b2eaee
to
4d15c86
Compare
BridgeAR
approved these changes
Aug 22, 2018
trivikr
approved these changes
Aug 23, 2018
jasnell
added
the
author ready
refack
approved these changes
Aug 23, 2018
`common.isCPPSymbolsNotMapped` is used only by the tests in the `test/tick-processor` folder. Move it local to those to get it out of `common`.
jasnell
force-pushed
the
test-move-common-tickprocessor
branch
from
4d15c86
to
7126f43
Compare
jasnell
added a commit
that referenced
this pull request
Aug 24, 2018
`common.isCPPSymbolsNotMapped` is used only by the tests in the `test/tick-processor` folder. Move it local to those to get it out of `common`. PR-URL: #22459 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Refael Ackermann <[email protected]>
|
Landed in 6bb96a1 |
addaleax
pushed a commit
that referenced
this pull request
Aug 27, 2018
`common.isCPPSymbolsNotMapped` is used only by the tests in the `test/tick-processor` folder. Move it local to those to get it out of `common`. PR-URL: #22459 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Refael Ackermann <[email protected]>
targos
pushed a commit
that referenced
this pull request
Sep 3, 2018
`common.isCPPSymbolsNotMapped` is used only by the tests in the `test/tick-processor` folder. Move it local to those to get it out of `common`. PR-URL: #22459 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Refael Ackermann <[email protected]>
targos
pushed a commit
that referenced
this pull request
Sep 6, 2018
`common.isCPPSymbolsNotMapped` is used only by the tests in the `test/tick-processor` folder. Move it local to those to get it out of `common`. PR-URL: #22459 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Refael Ackermann <[email protected]>
This was referenced Sep 6, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
common.isCPPSymbolsNotMappedis used only by the tests in thetest/tick-processorfolder. Move it local to those to get it out ofcommon.Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes