Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

os: destructure ERR_SYSTEM_ERROR properly #22394

Merged
merged 2 commits into from
Aug 20, 2018
Merged

os: destructure ERR_SYSTEM_ERROR properly #22394

merged 2 commits into from
Aug 20, 2018

Commits on Aug 20, 2018

  1. os: destructure ERR_SYSTEM_ERROR properly 

    PR-URL: nodejs#22394
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
    @cjihrig
    cjihrig committed Aug 20, 2018
    Configuration menu
    Copy the full SHA
    5e420f9 View commit details
    Browse the repository at this point in the history

  2. test: cover error case in os getCheckedFunction() 

    getCheckedFunction() is used internally by the os module to
handle errors from the binding layer in several methods. This
commit adds a test for the case where the binding layer returns
an error.

PR-URL: nodejs#22394
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
    @cjihrig
    cjihrig committed Aug 20, 2018
    Configuration menu
    Copy the full SHA
    8d05a15 View commit details
    Browse the repository at this point in the history