streams: move process.binding('stream_wrap') to internalBinding #22345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasnell
added
stream
|
@jasnell sadly an error occured when I tried to trigger a build :( |
nodejs-github-bot
added
the
lib / src
|
I'm seeing the following failure when running the test locally: $ out/Release/node /Users/danielbevenius/work/nodejs/node/test/pseudo-tty/test-tty-wrap.js
internal/modules/cjs/loader.js:583
throw err;
^
Error: Cannot find module 'internal/test/binding'
at Function.Module._resolveFilename (internal/modules/cjs/loader.js:581:15)
at Function.Module._load (internal/modules/cjs/loader.js:507:25)
at Module.require (internal/modules/cjs/loader.js:637:17)
at require (internal/modules/cjs/helpers.js:20:18)
at Object.<anonymous> (/Users/danielbevenius/work/nodejs/node/test/pseudo-tty/test-tty-wrap.js:4:29)
at Module._compile (internal/modules/cjs/loader.js:689:30)
at Object.Module._extensions..js (internal/modules/cjs/loader.js:700:10)
at Module.load (internal/modules/cjs/loader.js:599:32)
at tryModuleLoad (internal/modules/cjs/loader.js:538:12)
at Function.Module._load (internal/modules/cjs/loader.js:530:3) |
maclover7
approved these changes
Aug 16, 2018
| @@ -1,8 +1,9 @@ | |||
| 'use strict'; | |||
| require('../common'); | |||
|
|
|||
| const TTY = process.binding('tty_wrap').TTY; | |||
| const WriteWrap = process.binding('stream_wrap').WriteWrap; | |||
| const { internalBinding } = require('internal/test/binding'); | |||
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
joyeecheung
approved these changes
Aug 16, 2018
jasnell
added
lib / src
BridgeAR
approved these changes
Aug 17, 2018
| break; | ||
| default: | ||
| throw new Error(`invalid type: ${type}`); | ||
| function fail(err, syscall) { |
There was a problem hiding this comment.
AFAIK not all function have to be moved inside main, e.g., fail should be fine as is.
It should also be less churn if the arguments are just passed to the functions instead of moving the functions.
jasnell
force-pushed
the
stream-wrap-internal-binding
branch
from
86f9cf5
to
f7ead8a
Compare
|
Trying CI again: https://ci.nodejs.org/job/node-test-pull-request/16542/ |
jasnell
force-pushed
the
stream-wrap-internal-binding
branch
4 times, most recently
from
cf6aced
to
d305dfe
Compare
|
CI, again, after rebase: https://ci.nodejs.org/job/node-test-pull-request/16561/ |
|
linuxone build bot failed... trying again https://ci.nodejs.org/job/node-test-commit-linuxone/4131/ |
jasnell
force-pushed
the
stream-wrap-internal-binding
branch
from
d305dfe
to
ba2c323
Compare
|
@nodejs/build ... linuxone build bot is failing consistently. |
|
Resume Build: https://ci.nodejs.org/job/node-test-pull-request/16575/ |
jasnell
added a commit
to jasnell/node
that referenced
this pull request
Aug 19, 2018
PR-URL: nodejs#22345 Refs: nodejs#22160 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Jon Moss <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
|
Landed in 884b23d |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs: #22160
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes