test: add v8, vm, streams test benchmarks #22335
Conversation
|
I'm concerned that |
There was a problem hiding this comment.
OK, looking more closely: I understand the reasoning for wanting to add allowMultiple but I think the downside is much greater than the upside. The benchmark tests are not exhaustive. They are minimal and that is definitely on purpose. (Otherwise, they would take forever to run.) I think it would be best to make these conform to the existing tests and not add allowMultiple which will probably end up being abused at a later date.
|
Hmm, I thought about it being abused but assumed that such tests don't get changed often, therefore, they can be validated more thoroughly to avoid such abuse. |
lundibundi
force-pushed
the
add-more-test-benchmarks
branch
from
e7f5897
to
03635c2
Compare
lundibundi
changed the title
|
@BridgeAR is there a special place for these? I just put them where other such tests were. |
lundibundi
changed the title
Trott
force-pushed
the
add-more-test-benchmarks
branch
from
03635c2
to
f56e2d6
Compare
|
Rebased so fix jinja LICENSE thing in CI. CI: https://ci.nodejs.org/job/node-test-pull-request/16554/ |
|
Resume build: https://ci.nodejs.org/job/node-test-pull-request/16574/ |
|
Landed in d495e40...902fd40 |
Refs: #12068 PR-URL: #22335 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
Refs: #12068 PR-URL: #22335 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
Refs: #12068 PR-URL: #22335 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
Refs: #12068 PR-URL: #22335 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
Refs: #12068 PR-URL: #22335 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
Refs: #12068 PR-URL: #22335 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
Refs: #12068 PR-URL: #22335 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
Refs: #12068 PR-URL: #22335 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
Refs: #12068 PR-URL: #22335 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
Refs: #12068 PR-URL: #22335 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
Refs: #12068 PR-URL: #22335 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
Refs: #12068 PR-URL: #22335 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
Checklist
make -j4 test(UNIX) passes