Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: Fix the ServerResponse methods explainations to make it clear and not puzzled #22305

Closed
wants to merge 2 commits into from
Closed

doc: Fix the ServerResponse methods explainations to make it clear and not puzzled #22305

wants to merge 2 commits into from

Commits on Aug 15, 2018

  1. doc: Fix the ServerResponse methods explainations to make it clear 

    Ref: #14146.

In short: `ServerResponse` acutally inherits from `OutgoingMessage`,
with a series of methods like those in `Stream.Writable`. So we cannot
use `implements`(this has made poeple feel puzzled because there are
still many methods we don't need or have), so `inherits from Stream` is enough,
due to some core reasons and performance told by mcollina from the ref
(See some latest discussions at Ref).
    MaleDong committed Aug 15, 2018
    Configuration menu
    Copy the full SHA
    d909c28 View commit details
    Browse the repository at this point in the history

  2. Remove useless refs

    MaleDong committed Aug 15, 2018
    Configuration menu
    Copy the full SHA
    934c390 View commit details
    Browse the repository at this point in the history