Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: replace _WG_ with _team_ #22183

Closed
wants to merge 1 commit into from
Closed

doc: replace _WG_ with _team_ #22183

wants to merge 1 commit into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Aug 7, 2018

AFAICT, there is no N-API Working Group. There is an N-API team, but
AFAIK there is no charter etc. (And if I'm wrong and there is, then
https://nodejs.org/en/about/working-groups/ needs an update!)

Checklist

@Trott Trott added the fast-track PRs that do not need to wait for 48 hours to land. label Aug 7, 2018
@nodejs-github-bot
Copy link
Collaborator

@Trott build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/454/pipeline

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Aug 7, 2018
@Trott
Copy link
Member Author

Trott commented Aug 8, 2018 •
edited
Loading

Re-running lite job now that #22184 has landed.

@Trott
Copy link
Member Author

Trott commented Aug 8, 2018

Oops, forgot the URL: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/457/pipeline

@vsemozhetbyt
Copy link
Contributor

Node.js Collaborators, please, add 👍 here if you approve fast-tracking.

@Trott
Copy link
Member Author

Trott commented Aug 8, 2018

sigh and again: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/458/pipeline

@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Aug 8, 2018
@Trott
doc: replace _WG_ with _team_
dea2f90 
AFAICT, there is no N-API Working Group. There *is* an N-API team, but
AFAIK there is no charter etc. (And if I'm wrong and there is, then
https://nodejs.org/en/about/working-groups/ needs an update!)
@Trott
Copy link
Member Author

Trott commented Aug 8, 2018

Hmmm...it appears that the lite-pipeline job may not rebase against master. So it's not picking up the recently-landed fix. Guess I'll rebase and force push and see if that helps things along...

@Trott
Copy link
Member Author

Trott commented Aug 8, 2018

Lite CI: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/459/pipeline

@Trott
Copy link
Member Author

Trott commented Aug 8, 2018

@nodejs/tsc @nodejs/n-api

mcollina
mcollina approved these changes Aug 8, 2018
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

MylesBorins
MylesBorins approved these changes Aug 8, 2018
View reviewed changes
Copy link
Contributor

@MylesBorins MylesBorins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Trott added a commit to Trott/io.js that referenced this pull request Aug 8, 2018
@Trott
doc: replace _WG_ with _team_
fcb46a4 
AFAICT, there is no N-API Working Group. There *is* an N-API team, but
AFAIK there is no charter etc. (And if I'm wrong and there is, then
https://nodejs.org/en/about/working-groups/ needs an update!)

PR-URL: nodejs#22183
Reviewed-By: Vse Mozhet Byt <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Myles Borins <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@Trott
Copy link
Member Author

Trott commented Aug 8, 2018

Landed in fcb46a4

@Trott Trott closed this Aug 8, 2018
targos pushed a commit that referenced this pull request Aug 11, 2018
@Trott @targos
doc: replace _WG_ with _team_
99793b8 
AFAICT, there is no N-API Working Group. There *is* an N-API team, but
AFAIK there is no charter etc. (And if I'm wrong and there is, then
https://nodejs.org/en/about/working-groups/ needs an update!)

PR-URL: #22183
Reviewed-By: Vse Mozhet Byt <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Myles Borins <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@rvagg rvagg mentioned this pull request Aug 13, 2018
Merged
This was referenced Aug 16, 2018
Closed
Closed
Closed
Closed
Closed
Closed
Closed
This was referenced Aug 16, 2018
Closed
Closed
Closed
@Trott Trott deleted the terminology branch January 13, 2022 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vsemozhetbyt vsemozhetbyt vsemozhetbyt approved these changes

@cjihrig cjihrig cjihrig approved these changes

@lpinca lpinca lpinca approved these changes

@MylesBorins MylesBorins MylesBorins approved these changes

@mcollina mcollina mcollina approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@Trott @nodejs-github-bot @vsemozhetbyt @mcollina @MylesBorins @lpinca @cjihrig