Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused 3rd argument in assert.strictEqual() #22113

Closed

Conversation

yahavf6
Copy link
Contributor

@yahavf6 yahavf6 commented Aug 3, 2018

Line 9 contains a call to assert.strictEqual(). It has a string literal as the third argument. Unfortunately, that means that if there is an AssertionError, the value of status (the first argument) will not be reported. The third argument here is not adding any value (and in fact is reporting the wrong thing in the event of an AssertionError) so removed it.

Checklist
  • [x ] make -j4 test (UNIX), or vcbuild test (Windows) passes
  • [x ] commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added node-api Issues and PRs related to the Node-API. test Issues and PRs related to the tests. labels Aug 3, 2018
Copy link
Member

@Trott Trott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change to lib/assert.js introduces a breaking change to a public API. lib/assert.js should not be changed in this PR.

The change to the test is good.

@yahavf6 yahavf6 force-pushed the yahavf6-removeUnusedSSrtingError040818 branch from c71cacc to c188ca0 Compare August 4, 2018 17:28
@yahavf6
Copy link
Contributor Author

yahavf6 commented Aug 4, 2018

PR updated

@yahavf6
Copy link
Contributor Author

yahavf6 commented Aug 4, 2018 via email

@maclover7
Copy link
Contributor

@benjamingr
Copy link
Member

@yahavf6
Copy link
Contributor Author

yahavf6 commented Aug 7, 2018

Let's merge?

@maclover7 maclover7 added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Aug 7, 2018
Trott pushed a commit to Trott/io.js that referenced this pull request Aug 7, 2018
PR-URL: nodejs#22113
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Jon Moss <[email protected]>
Reviewed-By: Weijia Wang <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
@Trott
Copy link
Member

Trott commented Aug 7, 2018

Landed in 1284fa2.

Thanks for the contribution! 🎉

(If you're interested in other possible contributions to Node.js but don't have a good idea of where to start looking, some ideas are posted at https://www.nodetodo.org/next-steps/.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. node-api Issues and PRs related to the Node-API. test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants