Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: add rubys to collaborators #22109

Closed
wants to merge 2 commits into from
Closed

doc: add rubys to collaborators #22109

wants to merge 2 commits into from

Conversation

rubys
Copy link
Member

@rubys rubys commented Aug 3, 2018

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Aug 3, 2018
@rubys rubys added the notable-change PRs with changes that should be highlighted in changelogs. label Aug 3, 2018
README.md Outdated
@@ -470,6 +470,8 @@ For more information about the governance of the Node.js project, see
* [ronkorving](https://github.com/ronkorving) -
**Ron Korving** <[email protected]>
* [RReverser](https://github.com/RReverser) -
**Sam Ruby** <[email protected]>
* [rubys](https://github.com/rubys) -
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The lines above are reversed.

@vsemozhetbyt
Copy link
Contributor

Node.js Collaborators, please, add 👍 here if you approve fast-tracking.

@vsemozhetbyt vsemozhetbyt added fast-track PRs that do not need to wait for 48 hours to land. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels Aug 3, 2018
@rubys
Copy link
Member Author

rubys commented Aug 3, 2018

@rubys
Copy link
Member Author

rubys commented Aug 3, 2018

Landed in f19fa7c

@rubys rubys closed this Aug 3, 2018
rubys added a commit that referenced this pull request Aug 3, 2018
PR-URL: #22109
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Vse Mozhet Byt <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Bryan English <[email protected]>
targos pushed a commit that referenced this pull request Aug 4, 2018
PR-URL: #22109
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Vse Mozhet Byt <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Bryan English <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land. notable-change PRs with changes that should be highlighted in changelogs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants