src: yield empty maybes for failed AsyncWrap::MakeCallback calls #22078
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use an empty `MaybeLocal<Value>` as the return value for `AsyncWrap::MakeCallback()` if an exception occurred, regardless of `MakeCallback` depth. Unfortunately, the public API can not make this switch without a breaking change (and possibly some kind of deprecation/renaming).
nodejs-github-bot
added
c++
joyeecheung
approved these changes
Aug 2, 2018
ryzokuken
approved these changes
Aug 2, 2018
jasnell
approved these changes
Aug 3, 2018
addaleax
added
the
author ready
maclover7
approved these changes
Aug 11, 2018
|
Re-run custom suites CI: https://ci.nodejs.org/job/node-test-commit-custom-suites-freestyle/59/ |
jasnell
pushed a commit
that referenced
this pull request
Aug 12, 2018
Use an empty `MaybeLocal<Value>` as the return value for `AsyncWrap::MakeCallback()` if an exception occurred, regardless of `MakeCallback` depth. Unfortunately, the public API can not make this switch without a breaking change (and possibly some kind of deprecation/renaming). PR-URL: #22078 Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Ujjwal Sharma <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Jon Moss <[email protected]>
|
Landed in 45d0b4a |
|
@addaleax would you mind backporting this to v10.x-staging please? There's a change in master that removed an additional |
|
I think this applies cleanly now? |
|
@addaleax it applies cleanly but fails to compile. |
targos
removed
the
author ready
addaleax
added a commit
to addaleax/node
that referenced
this pull request
Aug 24, 2018
Use an empty `MaybeLocal<Value>` as the return value for `AsyncWrap::MakeCallback()` if an exception occurred, regardless of `MakeCallback` depth. Unfortunately, the public API can not make this switch without a breaking change (and possibly some kind of deprecation/renaming). PR-URL: nodejs#22078 Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Ujjwal Sharma <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Jon Moss <[email protected]>
addaleax
added a commit
that referenced
this pull request
Aug 28, 2018
Use an empty `MaybeLocal<Value>` as the return value for `AsyncWrap::MakeCallback()` if an exception occurred, regardless of `MakeCallback` depth. Unfortunately, the public API can not make this switch without a breaking change (and possibly some kind of deprecation/renaming). PR-URL: #22078 Backport-PR-URL: #22505 Reviewed-By: Michaël Zasso <[email protected]>
targos
pushed a commit
that referenced
this pull request
Sep 3, 2018
Use an empty `MaybeLocal<Value>` as the return value for `AsyncWrap::MakeCallback()` if an exception occurred, regardless of `MakeCallback` depth. Unfortunately, the public API can not make this switch without a breaking change (and possibly some kind of deprecation/renaming). PR-URL: #22078 Backport-PR-URL: #22505 Reviewed-By: Michaël Zasso <[email protected]>
targos
pushed a commit
that referenced
this pull request
Sep 6, 2018
Use an empty `MaybeLocal<Value>` as the return value for `AsyncWrap::MakeCallback()` if an exception occurred, regardless of `MakeCallback` depth. Unfortunately, the public API can not make this switch without a breaking change (and possibly some kind of deprecation/renaming). PR-URL: #22078 Backport-PR-URL: #22505 Reviewed-By: Michaël Zasso <[email protected]>
This was referenced Sep 6, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use an empty
MaybeLocal<Value>as the return value forAsyncWrap::MakeCallback()if an exception occurred,regardless of
MakeCallbackdepth.Unfortunately, the public API can not make this switch without
a breaking change (and possibly some kind of deprecation/renaming).
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes