https: allow url and options to be passed to https.request #22003

rubys · 2018-07-27T15:47:05Z

This completes #21616 by adding https which was inadvertently left out.

Checklist

make -j4 test (UNIX), or vcbuild test (Windows) passes
tests and/or benchmarks are included
commit message follows commit guidelines

mscdex · 2018-07-27T16:33:56Z

I would prefer avoiding adding new (underscore-prefixed) functions to the prototype.

I believe this could be resolved at least by one of:

Making HttpsClientRequest have no additional methods and checking this.constructor === HttpsClientRequest
Allow passing a 4th option to ClientRequest that if not undefined, must be a private symbol indicating an https client request
Make the few changes needed to the original code in https to support both url and options

Also, I think the commit message should technically have an https: prefix?

mcollina · 2018-07-27T17:19:12Z

lib/_http_client.js

+
+ClientRequest.prototype._defaultAgent = function() {
+  return Agent.globalAgent;
+};


I would avoid exposing those two directly. Maybe we should move them under a private Symbol?

mscdex · 2018-07-29T12:15:52Z

lib/https.js

-  return new ClientRequest(options, cb);
+  args.unshift(options);
+
+  return new ClientRequest(...args);


Last I checked, this was still significantly slower in V8 I think?

Fixed in Node 8.3? See https://github.com/davidmarkclements/v8-perf

Here’s the takeaway: if we want to write performant code around processing function inputs as an array (which in my experience seems fairly common), then in Node 8.3 and up we should use the spread operator.

Responding to your original suggestions:

Making HttpsClientRequest have no additional methods and checking this.constructor === HttpsClientRequest

The issue is that without additional methods, it never would be called... unless we duplicated the entire constructor.

Allow passing a 4th option to ClientRequest that if not undefined, must be a private symbol indicating an https client request

This will impact the ability to add future arguments. And we are currently dealing with three arguments, all optional...

Make the few changes needed to the original code in https to support both url and options

I went this way for now.

The other option:

Maybe we should move them under a private Symbol?

This is clean and would work. The symbols would need to be exported by lib/_http_client.js

This is clean and would work. The symbols would need to be exported by lib/_http_client.js

I would prefer it. Unfortunately there is a lot of monkey patching around core methods, and I would prefer this would be as private as possible. I would not block this for it.

If you feel strongly about going _, then ok.

@mcollina I'm not following.... in particular, I'm not sure what 'it' refers to.

Should I go back to the previous approach of subclassing ClientRequest for https, and introducing two new methods, this time with the method names being Symbols? My thoughts are that that approach is more understandable and maintainable.

Or would you prefer the current approach which duplicates a bit of code, but doesn't introduce any new methods. My thoughts are that approach is more private.

I was actually commenting on some old code. The current approach is fine. LGTM

Making HttpsClientRequest have no additional methods and checking this.constructor === HttpsClientRequest

The issue is that without additional methods, it never would be called... unless we duplicated the entire constructor.

@rubys I'm not sure what you mean, HttpsClientRequest would extend from ClientRequest and be empty itself (no explicit constructor or additional methods). Then inside ClientRequest, checking this.constructor like:

var defaultAgent = options._defaultAgent || (this.constructor === https[ClientRequestSym] ? https.globalAgent : Agent.globalAgent);

@McDex Fair point, but making that work would involve a circular require.

@rubys Not if it's lazy loaded.

mcollina

LGTM

mcollina · 2018-07-29T19:34:33Z

CI: https://ci.nodejs.org/job/node-test-pull-request/16066/

Trott · 2018-07-30T01:57:58Z

Resume Build: https://ci.nodejs.org/job/node-test-pull-request/16071/

Trott · 2018-08-01T01:22:00Z

I removed the author ready label because I'm not sure if the comments from @mscdex are blocking or if @rubys would want to address them first before landing regardless. Feel free to add the label back or to land the thing if I'm wrong. It's possible I'm being overly cautious.

rubys · 2018-08-01T01:35:11Z

I believe that this is ready to land. @McDex and @mcollina had similar concerns on my first implementation and collectively provided four alternatives. I selected and implemented @McDex's third option, and @mcollina approved the approach.

What remains is side conversation as to whether @McDex's first suggestion could also be made to work (it could, but wouldn't be as clear/straightforward as the third suggestion, in my opinion). Assuming that @McDex is still comfortable with his third suggestion (he should be, he suggested it :-)), I think we are good to go.

mscdex · 2018-08-01T04:20:57Z

I don't have a problem adding the missing code to https. My last comments were about a preferred way
for avoiding the code duplication.

Trott · 2018-08-01T05:29:22Z

@mscdex Just to make sure I'm understanding: You're OK with this landing without the lazy loading? That can be implemented in a subsequent PR or not at all and that's OK?

mscdex · 2018-08-01T05:41:44Z

@Trott My comment about the https lazy loading and constructor checking was one possible solution, one that would avoid the need to duplicate code. I am fine with either that or adding the missing code in https, which is what the PR does as of this writing.

Trott · 2018-08-01T05:54:08Z

Landed in 19aa41c

PR-URL: nodejs#22003 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: James M Snell <[email protected]>

targos · 2018-08-01T19:38:19Z

This should be backported along with #21616

PR-URL: nodejs#22003 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: James M Snell <[email protected]>

PR-URL: #22003 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: James M Snell <[email protected]> Backport-PR-URL: #21880 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Matteo Collina <[email protected]>

nodejs-github-bot added http Issues or PRs related to the http subsystem. https Issues or PRs related to the https subsystem. labels Jul 27, 2018

mcollina reviewed Jul 27, 2018

View reviewed changes

https: allow url and options to be passed to https.request

9f8f5d9

rubys force-pushed the https_url_options branch from 86109e4 to 9f8f5d9 Compare July 29, 2018 05:01

rubys changed the title ~~http: allow url and options to be passed to https.request~~ https: allow url and options to be passed to https.request Jul 29, 2018

mscdex reviewed Jul 29, 2018

View reviewed changes

mcollina approved these changes Jul 29, 2018

View reviewed changes

Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jul 30, 2018

jasnell approved these changes Jul 30, 2018

View reviewed changes

Trott removed the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Aug 1, 2018

Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Aug 1, 2018

Trott closed this Aug 1, 2018

Trott pushed a commit to Trott/io.js that referenced this pull request Aug 1, 2018

https: allow url and options to be passed to https.request

19aa41c

PR-URL: nodejs#22003 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: James M Snell <[email protected]>

targos added backport-requested-v10.x and removed author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels Aug 1, 2018

targos pushed a commit to targos/node that referenced this pull request Aug 2, 2018

https: allow url and options to be passed to https.request

0c748a4

PR-URL: nodejs#22003 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: James M Snell <[email protected]>

targos mentioned this pull request Aug 2, 2018

[v10.x] http: allow url and options to be passed to http*.request and http*.get #21880

Closed

targos added backported-to-v10.x and removed backport-requested-v10.x labels Aug 7, 2018

rvagg mentioned this pull request Aug 13, 2018

Release proposal: v10.9.0 #22295

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

https: allow url and options to be passed to https.request #22003

https: allow url and options to be passed to https.request #22003

rubys commented Jul 27, 2018 •

edited

Loading

mscdex commented Jul 27, 2018 •

edited

Loading

mcollina Jul 27, 2018

mscdex Jul 29, 2018 •

edited

Loading

rubys Jul 29, 2018

mcollina Jul 29, 2018

rubys Jul 29, 2018

mcollina Jul 29, 2018

mscdex Jul 29, 2018 •

edited

Loading

rubys Jul 29, 2018

mscdex Jul 29, 2018

mcollina left a comment

mcollina commented Jul 29, 2018

Trott commented Jul 30, 2018

Trott commented Aug 1, 2018

rubys commented Aug 1, 2018

mscdex commented Aug 1, 2018 •

edited

Loading

Trott commented Aug 1, 2018

mscdex commented Aug 1, 2018

Trott commented Aug 1, 2018

targos commented Aug 1, 2018

https: allow url and options to be passed to https.request #22003

https: allow url and options to be passed to https.request #22003

Conversation

rubys commented Jul 27, 2018 • edited Loading

Checklist

mscdex commented Jul 27, 2018 • edited Loading

mcollina Jul 27, 2018

Choose a reason for hiding this comment

mscdex Jul 29, 2018 • edited Loading

Choose a reason for hiding this comment

rubys Jul 29, 2018

Choose a reason for hiding this comment

mcollina Jul 29, 2018

Choose a reason for hiding this comment

rubys Jul 29, 2018

Choose a reason for hiding this comment

mcollina Jul 29, 2018

Choose a reason for hiding this comment

mscdex Jul 29, 2018 • edited Loading

Choose a reason for hiding this comment

rubys Jul 29, 2018

Choose a reason for hiding this comment

mscdex Jul 29, 2018

Choose a reason for hiding this comment

mcollina left a comment

Choose a reason for hiding this comment

mcollina commented Jul 29, 2018

Trott commented Jul 30, 2018

Trott commented Aug 1, 2018

rubys commented Aug 1, 2018

mscdex commented Aug 1, 2018 • edited Loading

Trott commented Aug 1, 2018

mscdex commented Aug 1, 2018

Trott commented Aug 1, 2018

targos commented Aug 1, 2018

rubys commented Jul 27, 2018 •

edited

Loading

mscdex commented Jul 27, 2018 •

edited

Loading

mscdex Jul 29, 2018 •

edited

Loading

mscdex Jul 29, 2018 •

edited

Loading

mscdex commented Aug 1, 2018 •

edited

Loading