gyp: muffle xcodebuild warnings #21999
Conversation
nodejs-github-bot
added
build
|
Should this land upstream first? |
Question for @nodejs/gyp , but I don't think we're doing that any more. cc/ @rvagg @gdams @bnoordhuis (who reviewed nodejs/node-gyp#1370, the equivalent patch in node-gyp). |
|
I believe at this point in time we effectively own the gyp stuff so I don't believe landing upstream in necessary. |
|
Nit on the commit message: (muffle makes it sound like we make it quieter and/or distort it. suppress makes it sound like we stop it from appearing.) |
| @@ -1442,6 +1442,18 @@ def CLTVersion(): | |||
| continue | |||
|
|
|||
|
|
|||
| def GetStdoutQuiet(cmdlist): | |||
There was a problem hiding this comment.
I don't like the method duplication.
This should be an overload.
👍
They are already not the same 😢, but I get your point. |
This seems like the most minimal diff, I didn't want to touch existing code more than absolutely necessary. There are very few people with any knowledge of gyp's internals to review the node-gyp change, so ease of review was more important than writing nice code, especially as gyp is basically deprecated at this point. I agree overloading is a slightly nicer code style, but I don't think it actually makes any difference beyond that. |
|
@refack are you convinced and okay with dismissing your review? |
Muffle xcodebuild warnings by introducing an alternative quieter alternative to GetStdout, called GetStdoutQuiet, and call it selectively in particularly noisy xcodebuild commands. Co-authored-by: Gibson Fahnestock <[email protected]> PR-URL: nodejs#21999 Original-PR-URL: nodejs/node-gyp#1370 Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
|
CI passed! Landing this. |
|
Landed in 16cffb0 |
Muffle xcodebuild warnings by introducing an alternative quieter alternative to GetStdout, called GetStdoutQuiet, and call it selectively in particularly noisy xcodebuild commands. Co-authored-by: Gibson Fahnestock <[email protected]> PR-URL: #21999 Original-PR-URL: nodejs/node-gyp#1370 Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
Muffle xcodebuild warnings by introducing an alternative quieter alternative to GetStdout, called GetStdoutQuiet, and call it selectively in particularly noisy xcodebuild commands. Co-authored-by: Gibson Fahnestock <[email protected]> PR-URL: #21999 Original-PR-URL: nodejs/node-gyp#1370 Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
Muffle xcodebuild warnings by introducing an alternative quieter alternative to GetStdout, called GetStdoutQuiet, and call it selectively in particularly noisy xcodebuild commands. Co-authored-by: Gibson Fahnestock <[email protected]> PR-URL: #21999 Original-PR-URL: nodejs/node-gyp#1370 Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
Muffle xcodebuild warnings by introducing an alternative quieter alternative to GetStdout, called GetStdoutQuiet, and call it selectively in particularly noisy xcodebuild commands. Co-authored-by: Gibson Fahnestock <[email protected]> PR-URL: #21999 Original-PR-URL: nodejs/node-gyp#1370 Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
Muffle xcodebuild warnings by introducing an alternative quieter
alternative to GetStdout, called GetStdoutQuiet, and call it selectively
in particularly noisy xcodebuild commands.
Co-authored-by: Gibson Fahnestock [email protected]
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes/cc @gibfahn @nodejs/gyp