Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc : Fix incorrect method name #21908

Closed
wants to merge 1 commit into from
Closed

Conversation

antsmartian
Copy link
Contributor

@antsmartian antsmartian commented Jul 20, 2018

Fixes #21904

  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@vsemozhetbyt
Copy link
Contributor

@vsemozhetbyt
Copy link
Contributor

Node.js Collaborators, please, add 👍 here if you approve fast-tracking.

@vsemozhetbyt vsemozhetbyt added doc Issues and PRs related to the documentations. vm Issues and PRs related to the vm subsystem. labels Jul 20, 2018
@vsemozhetbyt vsemozhetbyt added the fast-track PRs that do not need to wait for 48 hours to land. label Jul 20, 2018
vsemozhetbyt pushed a commit that referenced this pull request Jul 20, 2018
PR-URL: #21908
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Vse Mozhet Byt <[email protected]>
Reviewed-By: Lance Ball <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@vsemozhetbyt
Copy link
Contributor

Landed in 79e63c5
Thank you!

@antsmartian
Copy link
Contributor Author

antsmartian commented Jul 20, 2018

Wow, that's so quick. Thanks everyone, cc @vsemozhetbyt .

targos pushed a commit that referenced this pull request Jul 20, 2018
PR-URL: #21908
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Vse Mozhet Byt <[email protected]>
Reviewed-By: Lance Ball <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@antsmartian antsmartian deleted the 21904 branch July 20, 2018 18:02
@targos targos mentioned this pull request Jul 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land. vm Issues and PRs related to the vm subsystem.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants