Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v10.x] lib,src: replace all C++ promises with JS promises #21879

Closed
wants to merge 1 commit into from
Closed

[v10.x] lib,src: replace all C++ promises with JS promises #21879

wants to merge 1 commit into from

Commits on Jul 19, 2018

  1. lib,src: replace all C++ promises with JS promises 

    C++ promises can not be properly optimized by V8. They also behave
a tiny bit different than "regular" promises.

PR-URL: nodejs#20830
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Gus Caplan <[email protected]>
Reviewed-By: Tiancheng "Timothy" Gu <[email protected]>
Reviewed-By: Benedikt Meurer <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
    @BridgeAR @targos
    BridgeAR authored and targos committed Jul 19, 2018
    Configuration menu
    Copy the full SHA
    e637159 View commit details
    Browse the repository at this point in the history