Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tls: named anonymous functions in _tls_wrap.js #21756

Closed
wants to merge 1 commit into from
Closed

tls: named anonymous functions in _tls_wrap.js #21756

wants to merge 1 commit into from

Conversation

prayag21
Copy link
Contributor

Refs: #8913

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the tls Issues and PRs related to the tls subsystem. label Jul 11, 2018
@trivikr
Copy link
Member

trivikr commented Jul 11, 2018

Thank you @prayag21 for your first PR to Node.js core! 🎉

CI: https://ci.nodejs.org/job/node-test-pull-request/15801/

@trivikr trivikr added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jul 11, 2018
@maclover7
Copy link
Contributor

Looks like there is a legitimate linter failure here, one of the lines is over 80 characters:

11:41:34 not ok 14 - /usr/home/iojs/build/workspace/node-test-linter/lib/_tls_wrap.js
11:41:34   ---
11:41:34   message: Line 1101 exceeds the maximum line length of 80.
11:41:34   severity: error
11:41:34   data:
11:41:34     line: 1101
11:41:34     column: 1
11:41:34     ruleId: max-len
11:41:34   ...
11:41:34 + exit 1

@trivikr
Copy link
Member

trivikr commented Jul 14, 2018

@prayag21 Can you please fix the linter failure shared by @maclover7 and update the PR?

  • Steps to update PR are given here
  • Ensure that make lint (or vcbuild.bat lint on Windows) is successful in your workspace (as described in Step 3)

BridgeAR pushed a commit to BridgeAR/node that referenced this pull request Jul 18, 2018
@prayag21 @BridgeAR
tls: named anonymous functions in _tls_wrap.js
39902e2 
PR-URL: nodejs#21756
Refs: nodejs#8913
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
@BridgeAR
Copy link
Member

Landed in 39902e2 🎉

I fixed the linter issue while landing.

@prayag21 congratulations on your first commit to Node.js!

@BridgeAR BridgeAR closed this Jul 18, 2018
@targos targos removed the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jul 19, 2018
targos pushed a commit that referenced this pull request Jul 19, 2018
@prayag21 @targos
tls: named anonymous functions in _tls_wrap.js
580071d 
PR-URL: #21756
Refs: #8913
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
@prayag21
Copy link
Contributor Author

@BridgeAR Thank you so much for fixing the linter issue.

@targos targos mentioned this pull request Jul 31, 2018
Merged
This was referenced Aug 1, 2018
Closed
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trivikr trivikr trivikr approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

@lpinca lpinca lpinca approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
tls Issues and PRs related to the tls subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@prayag21 @trivikr @maclover7 @BridgeAR @jasnell @lpinca @targos @nodejs-github-bot