util: add inspect suffix to BigInt64Array elements #21499
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
not-an-aardvark
added
the
semver-major
nodejs-github-bot
added
the
util
This commit updates `util.inspect` to add an `n` suffix to BigInts that appear in BigInt64Arrays. BigInts are formatted with an `n` suffix in most cases, but this did not occur in BigInt64Arrays due to an apparent oversight where the implementation of `inspect` for typed arrays assumed that all typed array elements are numbers.
not-an-aardvark
force-pushed
the
format-bigint64array-elements
branch
from
5f86252
to
7e000dc
Compare
targos
approved these changes
Jun 24, 2018
devsnek
reviewed
Jun 24, 2018
lib/util.js
Outdated
| @@ -897,8 +901,12 @@ function formatTypedArray(ctx, value, recurseTimes, keys) { | |||
| const maxLength = Math.min(Math.max(0, ctx.maxArrayLength), value.length); | |||
| const remaining = value.length - maxLength; | |||
| const output = new Array(maxLength + (remaining > 0 ? 1 : 0)); | |||
| const elementFormatter = | |||
| types.isBigInt64Array(value) || types.isBigUint64Array(value) ? | |||
There was a problem hiding this comment.
typeof value[0] will be waaaaaay faster
There was a problem hiding this comment.
That would result in elementFormatter having the wrong value when the array is empty, although admittedly it wouldn't matter in that case because elementFormatter would never be called. I'll change it to use typeof.
devsnek
approved these changes
Jun 24, 2018
BridgeAR
approved these changes
Jun 24, 2018
lib/util.js
Outdated
| @@ -897,8 +901,11 @@ function formatTypedArray(ctx, value, recurseTimes, keys) { | |||
| const maxLength = Math.min(Math.max(0, ctx.maxArrayLength), value.length); | |||
| const remaining = value.length - maxLength; | |||
| const output = new Array(maxLength + (remaining > 0 ? 1 : 0)); | |||
| const elementFormatter = typeof value[0] === 'number' ? | |||
There was a problem hiding this comment.
Please change it to:
const formatter = len !== 0 && typeof value[0] === 'number' ?
formatNumber :
formatBigInt;Otherwise the OOB access for an empty TypedArray slows down all following calls.
TimothyGu
approved these changes
Jun 24, 2018
cjihrig
approved these changes
Jun 24, 2018
TimothyGu
reviewed
Jun 24, 2018
| @@ -897,8 +901,11 @@ function formatTypedArray(ctx, value, recurseTimes, keys) { | |||
| const maxLength = Math.min(Math.max(0, ctx.maxArrayLength), value.length); | |||
| const remaining = value.length - maxLength; | |||
| const output = new Array(maxLength + (remaining > 0 ? 1 : 0)); | |||
| const elementFormatter = value.length > 0 && typeof value[0] === 'number' ? | |||
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
benjamingr
approved these changes
Jun 24, 2018
jasnell
approved these changes
Jun 24, 2018
hiroppy
approved these changes
Jun 25, 2018
|
Landed in 80496a5 |
not-an-aardvark
added a commit
that referenced
this pull request
Jun 28, 2018
This commit updates `util.inspect` to add an `n` suffix to BigInts that appear in BigInt64Arrays. BigInts are formatted with an `n` suffix in most cases, but this did not occur in BigInt64Arrays due to an apparent oversight where the implementation of `inspect` for typed arrays assumed that all typed array elements are numbers. PR-URL: #21499 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Tiancheng "Timothy" Gu <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Yuta Hiroto <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesThis commit updates
util.inspectto add annsuffix to BigInts thatappear in BigInt64Arrays. BigInts are formatted with an
nsuffix inmost cases, but this did not occur in BigInt64Arrays due to an apparent
oversight where the implementation of
inspectfor typed arrays assumedthat all typed array elements are numbers.