fs: undeprecate lchown() #21498

cjihrig · 2018-06-24T05:22:30Z

uv_fs_lchown() exists, as of libuv 1.21.0. fs.lchown() can now be undeprecated. This commit also adds tests, as there were none. As with fs.chown() and fs.fchown(), the tests are somewhat limited.

Fixes: #19868

Checklist

make -j4 test (UNIX), or vcbuild test (Windows) passes
tests and/or benchmarks are included
documentation is changed or added
commit message follows commit guidelines

nodejs-github-bot · 2018-06-24T05:22:31Z

@cjihrig build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/140/pipeline

cjihrig · 2018-06-24T05:22:38Z

CI: https://ci.nodejs.org/job/node-test-commit/19401/

benjamingr · 2018-06-24T18:48:27Z

doc/api/deprecations.md


 <a id="DEP0038"></a>
 ### DEP0038: fs.lchownSync(path, uid, gid)

 Type: Documentation-only

-The [`fs.lchownSync(path, uid, gid)`][] API is deprecated.
+The [`fs.lchownSync(path, uid, gid)`][] API was previously deprecated. As of


Given it was never hard-deprecated or removed - I'm not sure it's not best to remove this entirely.

benjamingr · 2018-06-24T18:49:11Z

doc/api/fs.md

@@ -1918,6 +1920,8 @@ changes:
    pr-url: https://github.com/nodejs/node/pull/7897
    description: The `callback` parameter is no longer optional. Not passing
                 it will emit a deprecation warning with id DEP0013.
+  - version: v0.4.7


I also think it makes sense to remove the deprecation entirely since there is no effect about this being deprecated in earlier versions and it was doc-deprecated anyway.

benjamingr · 2018-06-24T18:50:01Z

doc/api/fs.md

+    pr-url: https://github.com/nodejs/node/pull/XXXXX-replace
+    description: This API is no longer deprecated.
+  - version: v10.0.0
+    description: This API is deprecated.


I don't see a point in keeping this deprecation regardless of the other one since fsPromises is experimental

src/node_file.cc

+  const int argc = args.Length();
+  CHECK_GE(argc, 3);
+
+  BufferValue path(env->isolate(), args[0]);


benjamingr · 2018-06-24T18:52:25Z

test/parallel/test-fs-lchown.js

@@ -0,0 +1,50 @@
+'use strict';
+
+const common = require('../common');


If there are other tests you think we should add to lchown, let me know and we'll make good-first-issues out of them

We're pretty light on chown(), fchown(), and lchown() happy path tests in general. My guess is because of platform support and getting the uid and gid parts right on the CI.

benjamingr · 2018-06-24T18:53:33Z

Code of commit 5a08026 LGTM but would prefer it if someone with more libuv experience approves :)

Nice work!

uv_fs_lchown() exists, as of libuv 1.21.0. fs.lchown() can now be undeprecated. This commit also adds tests, as there were none. PR-URL: nodejs#21498 Fixes: nodejs#19868 Reviewed-By: Wyatt Preul <[email protected]>

cjihrig · 2018-06-27T15:38:14Z

Updated as requested.

CI: https://ci.nodejs.org/job/node-test-pull-request/15652/
The inspector failures on Windows are not related.

uv_fs_lchown() exists, as of libuv 1.21.0. fs.lchown() can now be undeprecated. This commit also adds tests, as there were none. PR-URL: #21498 Fixes: #19868 Reviewed-By: Wyatt Preul <[email protected]>

ChALkeR · 2018-07-01T19:12:54Z

@nodejs/tsc

According the the git history, this is the first commit which removes deprecation numbers from the documentation. Is that intended?

Trott · 2018-07-01T22:53:29Z

@ChALkeR As long as the deprecation number is never re-used, I'm personally OK with removing a deprecation number from the docs if it is unused in the corresponding Node.js version. (I'm also OK with leaving it in, with or without an indication that it is no longer used.)

Notable changes: * build: * Node.js should now be about 60% faster to startup than the previous version, thanks to the use V8's code cache feature for core modules. [#21405](#21405) * dns: * An experimental promisified version of the dns module is now available. Give it a try with `require('dns').promises`. [#21264](#21264) * fs: * `fs.lchown` has been undeprecated now that libuv supports it. [#21498](#21498) * lib: * `Atomics.wake` is being renamed to `Atomics.notify` in the ECMAScript specification ([reference](tc39/ecma262#1220)). Since Node.js now has experimental support for worker threads, we are being proactive and added a `notify` alias, while emitting a warning if `wake` is used. [#21413](#21413) [#21518](#21518) * n-api: * Add API for asynchronous functions. [#17887](#17887) * util: * `util.inspect` is now able to return a result instead of throwing when the maximum call stack size is exceeded during inspection. [#20725](#20725) * vm: * Add `script.createCachedData()`. This API replaces the `produceCachedData` option of the `Script` constructor that is now deprecated. [#20300](#20300) * worker: * Support for relative paths has been added to the `Worker` constructor. Paths are interpreted relative to the current working directory. [#21407](#21407) PR-URL: #21629

Notable changes: * dns: * An experimental promisified version of the dns module is now available. Give it a try with `require('dns').promises`. [#21264](#21264) * fs: * `fs.lchown` has been undeprecated now that libuv supports it. [#21498](#21498) * lib: * `Atomics.wake` is being renamed to `Atomics.notify` in the ECMAScript specification ([reference](tc39/ecma262#1220)). Since Node.js now has experimental support for worker threads, we are being proactive and added a `notify` alias, while emitting a warning if `wake` is used. [#21413](#21413) [#21518](#21518) * n-api: * Add API for asynchronous functions. [#17887](#17887) * util: * `util.inspect` is now able to return a result instead of throwing when the maximum call stack size is exceeded during inspection. [#20725](#20725) * vm: * Add `script.createCachedData()`. This API replaces the `produceCachedData` option of the `Script` constructor that is now deprecated. [#20300](#20300) * worker: * Support for relative paths has been added to the `Worker` constructor. Paths are interpreted relative to the current working directory. [#21407](#21407) PR-URL: #21629

nodejs-github-bot added the libuv Issues and PRs related to the libuv dependency or the uv binding. label Jun 24, 2018

benjamingr reviewed Jun 24, 2018

View reviewed changes

src/node_file.cc

const int argc = args.Length();

CHECK_GE(argc, 3);

BufferValue path(env->isolate(), args[0]);

This comment was marked as off-topic.

Sign in to view

benjamingr reviewed Jun 24, 2018

View reviewed changes

cjihrig force-pushed the lchown branch from 5a08026 to 85c6651 Compare June 25, 2018 01:19

cjihrig mentioned this pull request Jun 25, 2018

test: add tests for fsPromises.chown to increase coverage #20574

Closed

2 tasks

geek approved these changes Jun 26, 2018

View reviewed changes

cjihrig force-pushed the lchown branch 3 times, most recently from 11cd3f4 to ea9d597 Compare June 27, 2018 14:37

fs: undeprecate lchown()

7ff50f9

uv_fs_lchown() exists, as of libuv 1.21.0. fs.lchown() can now be undeprecated. This commit also adds tests, as there were none. PR-URL: nodejs#21498 Fixes: nodejs#19868 Reviewed-By: Wyatt Preul <[email protected]>

cjihrig force-pushed the lchown branch from ea9d597 to 7ff50f9 Compare June 27, 2018 15:37

cjihrig merged commit 7ff50f9 into nodejs:master Jun 27, 2018

cjihrig deleted the lchown branch June 27, 2018 15:39

shisama mentioned this pull request Jun 30, 2018

fs: fix fsPromises.lchmod errors on non-Mac #21435

Merged

3 tasks

ChALkeR mentioned this pull request Jul 1, 2018

doc: remove 2 unused error codes from errors.md #21491

Merged

4 tasks

targos mentioned this pull request Jul 3, 2018

v10.6.0 proposal #21629

Merged

tniessen added fs Issues and PRs related to the fs subsystem / file system. deprecations Issues and PRs related to deprecations. labels Sep 8, 2018

tniessen mentioned this pull request Sep 9, 2018

doc: add full deprecation history #22766

Closed

3 tasks

RyanZim mentioned this pull request Dec 19, 2020

Add basic ESM support jprichardson/node-fs-extra#854

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fs: undeprecate lchown() #21498

fs: undeprecate lchown() #21498

cjihrig commented Jun 24, 2018 •

edited

Loading

nodejs-github-bot commented Jun 24, 2018

cjihrig commented Jun 24, 2018

benjamingr Jun 24, 2018

benjamingr Jun 24, 2018

benjamingr Jun 24, 2018

This comment was marked as off-topic.

benjamingr Jun 24, 2018

cjihrig Jun 25, 2018

benjamingr commented Jun 24, 2018

cjihrig commented Jun 27, 2018

ChALkeR commented Jul 1, 2018 •

edited

Loading

Trott commented Jul 1, 2018

		@@ -0,0 +1,50 @@
		'use strict';

		const common = require('../common');

fs: undeprecate lchown() #21498

fs: undeprecate lchown() #21498

Conversation

cjihrig commented Jun 24, 2018 • edited Loading

Checklist

nodejs-github-bot commented Jun 24, 2018

cjihrig commented Jun 24, 2018

benjamingr Jun 24, 2018

Choose a reason for hiding this comment

benjamingr Jun 24, 2018

Choose a reason for hiding this comment

benjamingr Jun 24, 2018

Choose a reason for hiding this comment

This comment was marked as off-topic.

benjamingr Jun 24, 2018

Choose a reason for hiding this comment

cjihrig Jun 25, 2018

Choose a reason for hiding this comment

benjamingr commented Jun 24, 2018

cjihrig commented Jun 27, 2018

ChALkeR commented Jul 1, 2018 • edited Loading

Trott commented Jul 1, 2018

cjihrig commented Jun 24, 2018 •

edited

Loading

ChALkeR commented Jul 1, 2018 •

edited

Loading