Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fs: fix fsPromises.lchmod errors on non-Mac #21435

Merged
merged 1 commit into from
Jul 10, 2018
Merged

fs: fix fsPromises.lchmod errors on non-Mac #21435

merged 1 commit into from
Jul 10, 2018
+14 −3

Commits on Jul 10, 2018

  1. fs: fix fsPromises.lchmod error on non-Mac 

    On non-macOS, fsPromises.lchmod throws AssertionError.
Expected behavior is `Error [ERR_METHOD_NOT_IMPLEMENTED]`.
`ERR_METHOD_NOT_IMPLEMENTED()` requires argument, but it wasn't set.

Fixes `ERR_METHOD_NOT_IMPLEMENTED()` to
`ERR_METHOD_NOT_IMPLEMENTED('lchmod()')`.

PR-URL: nodejs#21435
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Weijia Wang <[email protected]>
Reviewed-By: Сковорода Никита Андреевич <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Yuta Hiroto <[email protected]>
    @ChALkeR
    Masashi Hirano authored and ChALkeR committed Jul 10, 2018
    Configuration menu
    Copy the full SHA
    f54958e View commit details
    Browse the repository at this point in the history