Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: improve assert error messages #21160

Closed
wants to merge 2 commits into from
Closed

test: improve assert error messages #21160

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0f75410
test: improve assert error messages
hristijankiko Jun 6, 2018
132b789
test: remove unnecessary string template
hristijankiko Jun 7, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 14 additions & 6 deletions test/parallel/test-stream-pipe-await-drain.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,12 @@ writer1._write = common.mustCall(function(chunk, encoding, cb) {
}, 1);

writer1.once('chunk-received', function() {
assert.strictEqual(reader._readableState.awaitDrain, 0,
'initial value is not 0');
assert.strictEqual(
reader._readableState.awaitDrain,
0,
'awaitDrain initial value should be 0, actual is ' +
`${reader._readableState.awaitDrain}`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since there's only a variable in the template, you can just use the variable with no template at all:

    reader._readableState.awaitDrain

);
setImmediate(function() {
// This one should *not* get through to writer1 because writer2 is not
// "done" processing.
Expand All @@ -35,8 +39,10 @@ writer1.once('chunk-received', function() {
// A "slow" consumer:
writer2._write = common.mustCall(function(chunk, encoding, cb) {
assert.strictEqual(
reader._readableState.awaitDrain, 1,
'awaitDrain isn\'t 1 after first push'
reader._readableState.awaitDrain,
1,
'awaitDrain should be 1 after first push, actual is ' +
`${reader._readableState.awaitDrain}`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same comment here as above.

);
// Not calling cb here to "simulate" slow stream.
// This should be called exactly once, since the first .write() call
Expand All @@ -45,8 +51,10 @@ writer2._write = common.mustCall(function(chunk, encoding, cb) {

writer3._write = common.mustCall(function(chunk, encoding, cb) {
assert.strictEqual(
reader._readableState.awaitDrain, 2,
'awaitDrain isn\'t 2 after second push'
reader._readableState.awaitDrain,
2,
'awaitDrain should be 2 after second push, actual is ' +
`${reader._readableState.awaitDrain}`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

...and here as well.

);
// Not calling cb here to "simulate" slow stream.
// This should be called exactly once, since the first .write() call
Expand Down