Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lib: use focused ESLint disabling in util.js #21041

Closed
wants to merge 1 commit into from
Closed

lib: use focused ESLint disabling in util.js #21041

wants to merge 1 commit into from

Conversation

Trott
Copy link
Member

@Trott Trott commented May 30, 2018

Instead of disabling all ESLint rules for two lines that require a
violation of no-control-regex, disable only the no-control-regex rule.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@Trott
lib: use focused ESLint disabling in util.js
51f0501 
Instead of disabling all ESLint rules for two lines that require a
violation of no-control-regex, disable only the no-control-regex rule.
@nodejs-github-bot nodejs-github-bot added the util Issues and PRs related to the built-in util module. label May 30, 2018
@Trott
Copy link
Member Author

Trott commented May 30, 2018

Lite CI: https://ci.nodejs.org/job/node-test-pull-request-lite/771/

@vsemozhetbyt vsemozhetbyt added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label May 30, 2018
@sindresorhus
Copy link

I would recommend the unicorn/no-abusive-eslint-disable rule, which ensures the disable comments are always specific.

@nodejs nodejs deleted a comment from refack Jun 1, 2018
@Trott Trott closed this Jun 1, 2018
@Trott Trott reopened this Jun 1, 2018
@Trott
Copy link
Member Author

Trott commented Jun 1, 2018

Landed in 6cda5a9

@Trott Trott closed this Jun 1, 2018
Trott added a commit to Trott/io.js that referenced this pull request Jun 1, 2018
@Trott
lib: use focused ESLint disabling in util.js
6cda5a9 
Instead of disabling all ESLint rules for two lines that require a
violation of no-control-regex, disable only the no-control-regex rule.

PR-URL: nodejs#21041
Reviewed-By: Gus Caplan <[email protected]>
Reviewed-By: Vse Mozhet Byt <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Weijia Wang <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
MylesBorins pushed a commit that referenced this pull request Jun 6, 2018
@Trott @MylesBorins
lib: use focused ESLint disabling in util.js
a30bf55 
Instead of disabling all ESLint rules for two lines that require a
violation of no-control-regex, disable only the no-control-regex rule.

PR-URL: #21041
Reviewed-By: Gus Caplan <[email protected]>
Reviewed-By: Vse Mozhet Byt <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Weijia Wang <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Jun 6, 2018
Merged
@Trott Trott deleted the berlin-2 branch January 13, 2022 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trivikr trivikr trivikr approved these changes

@starkwang starkwang starkwang approved these changes

@vsemozhetbyt vsemozhetbyt vsemozhetbyt approved these changes

@devsnek devsnek devsnek approved these changes

@lpinca lpinca lpinca approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. util Issues and PRs related to the built-in util module.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@Trott @sindresorhus @jasnell @lpinca @devsnek @vsemozhetbyt @starkwang @trivikr @nodejs-github-bot