doc: remove vestigial onboarding section #21028
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The onboarding-extras doc includes a section with a single bullet point instructing the new Collaborator to write good pull request descriptions. This material is likely superfluous and is in the wrong document if it is not. (It more properly belongs in pull-requests.md as it is information that is not specific to new Collaborators.) I am not putting it in pullrequests.md because that document is already plenty long and detailed, and includes advice on writing good commit messages, which tend to become the pull request descriptions anyway.
maclover7
approved these changes
May 30, 2018
vsemozhetbyt
approved these changes
May 30, 2018
vsemozhetbyt
added
meta
TimothyGu
approved these changes
May 30, 2018
jasnell
approved these changes
May 30, 2018
lpinca
approved these changes
May 30, 2018
|
👍 here for fast-tracking. |
trivikr
approved these changes
May 31, 2018
|
Landed in 7dca329 |
apapirovski
pushed a commit
that referenced
this pull request
Jun 1, 2018
The onboarding-extras doc includes a section with a single bullet point instructing the new Collaborator to write good pull request descriptions. This material is likely superfluous and is in the wrong document if it is not. (It more properly belongs in pull-requests.md as it is information that is not specific to new Collaborators.) I am not putting it in pullrequests.md because that document is already plenty long and detailed, and includes advice on writing good commit messages, which tend to become the pull request descriptions anyway. PR-URL: #21028 Reviewed-By: Jon Moss <[email protected]> Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Tiancheng "Timothy" Gu <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Jun 6, 2018
The onboarding-extras doc includes a section with a single bullet point instructing the new Collaborator to write good pull request descriptions. This material is likely superfluous and is in the wrong document if it is not. (It more properly belongs in pull-requests.md as it is information that is not specific to new Collaborators.) I am not putting it in pullrequests.md because that document is already plenty long and detailed, and includes advice on writing good commit messages, which tend to become the pull request descriptions anyway. PR-URL: #21028 Reviewed-By: Jon Moss <[email protected]> Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Tiancheng "Timothy" Gu <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The onboarding-extras doc includes a section with a single bullet point
instructing the new Collaborator to write good pull request
descriptions. This material is likely superfluous and is in the wrong
document if it is not. (It more properly belongs in pull-requests.md as
it is information that is not specific to new Collaborators.) I am not
putting it in pullrequests.md because that document is already plenty
long and detailed, and includes advice on writing good commit messages,
which tend to become the pull request descriptions anyway.
Checklist