Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: re-integrate headers into node.h #20939

Closed
wants to merge 1 commit into from
Closed

src: re-integrate headers into node.h #20939

wants to merge 1 commit into from

Commits on May 24, 2018

  1. src: re-integrate headers into node.h 

    Alternative to nodejs#20938
(clean revert) and nodejs#20925
(adding the headers to the release tarball).

The changes to `src/node.h` are a clean revert in the
same ways as nodejs#20938 does it,
the difference being that the new `.cc` files are kept here.

This has the advantage of not being another large diff that
other PRs will have to rebase against, especially since
the split into `callback_scope.cc` and `exceptions.cc` is
something that we want to keep in the long run.

This essentialy implements bnoordhuis’s suggestion from
nodejs#20925.
    @addaleax
    addaleax committed May 24, 2018
    Configuration menu
    Copy the full SHA
    894c524 View commit details
    Browse the repository at this point in the history