Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: use log only in test-child-process-fork-net #20873

Closed
wants to merge 1 commit into from
Closed

test: use log only in test-child-process-fork-net #20873

wants to merge 1 commit into from

Commits on May 21, 2018

  1. test: use log only in test-child-process-fork-net 

    We are currently having issues with test-child-process-fork-net on
Windows CI. Debugging is slightly hampered by the mix of `console.log()`
and `console.error()` as our test runner does not interleave stdout and
stderr, so the order of output is not preserved. Change the sole
instance of `console.error()` to `console.log()` to improve
debugability.

While editing, I also took the opportunity to add capitalization and
punctuation to comments (as that is a nit we see from time to time and
there is a potential ESLint rule to enforce the capitalization part).
    @Trott
    Trott committed May 21, 2018
    Configuration menu
    Copy the full SHA
    dda45c8 View commit details
    Browse the repository at this point in the history