Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: changed assert message from string literal to template literal #20870

Closed
wants to merge 1 commit into from
Closed

test: changed assert message from string literal to template literal #20870

wants to merge 1 commit into from

Conversation

CoreyGMartin
Copy link
Contributor

@CoreyGMartin CoreyGMartin commented May 21, 2018 •
edited
Loading

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label May 21, 2018
@Trott
Copy link
Member

Trott commented May 22, 2018

CI: https://ci.nodejs.org/job/node-test-pull-request/15009/

@Trott Trott added the fast-track PRs that do not need to wait for 48 hours to land. label May 23, 2018
@Trott
Copy link
Member

Trott commented May 23, 2018

CI is yellow. It seems like this can be fast-tracked. If you're a Collaborator and approve fast-tracking this, please 👍 this comment. Thanks!

@apapirovski apapirovski added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label May 23, 2018
jasnell pushed a commit that referenced this pull request May 23, 2018
@CoreyGMartin @jasnell
test: changed assert message from string literal to template literal
6e8abb1 
PR-URL: #20870
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Khaidi Chu <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
@jasnell
Copy link
Member

jasnell commented May 23, 2018

Landed in 6e8abb1

@jasnell jasnell closed this May 23, 2018
targos pushed a commit that referenced this pull request May 25, 2018
@CoreyGMartin @targos
test: changed assert message from string literal to template literal
ed84b7d 
PR-URL: #20870
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Khaidi Chu <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
@MylesBorins MylesBorins mentioned this pull request May 29, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@Trott Trott Trott approved these changes

@XadillaX XadillaX XadillaX approved these changes

@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes

@trivikr trivikr trivikr approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. fast-track PRs that do not need to wait for 48 hours to land. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@CoreyGMartin @Trott @jasnell @XadillaX @gireeshpunathil @trivikr @apapirovski @nodejs-github-bot