trace_events: add version metadata #20852
Conversation
nodejs-github-bot
added
the
c++
|
Failures in CI are known flakies |
|
Mimic in which way? |
src/node.cc
Outdated
| @@ -4234,6 +4234,11 @@ inline int Start(Isolate* isolate, IsolateData* isolate_data, | |||
| Environment env(isolate_data, context, v8_platform.GetTracingAgent()); | |||
| env.Start(argc, argv, exec_argc, exec_argv, v8_is_profiling); | |||
|
|
|||
| TRACE_EVENT_METADATA1("__metadata", "version", "node", NODE_VERSION + 1); | |||
There was a problem hiding this comment.
nit: I'm trying to understand the + 1. If you're skipping the v in the version string: 1) why? 2) it would be good to add a comment explaining what the + 1 does as it is not immediately obvious. I would prefer if the v was included too.
There was a problem hiding this comment.
i thought we had a lint rule against messing with pointers like that
There was a problem hiding this comment.
It is for consistency with the value of process.versions.node (which does not include the v)
There was a problem hiding this comment.
If we don't want the v why not use NODE_VERSION_STRING instead?
Line 65 in 32873c5
|
@ofrobots ... btw, I was going to output all of the versions with a single I don't want this to get too out of sync with the V8 version, but it would be helpful to have a |
I meant using the same names (for example n-api vs napi), and including the other missing dependencies. |
Certainly can do that, yes. |
Use `TRACE_EVENT_METADATA1` to include just the node.js version for now. Later this can be expanded to include more version and platform details.
jasnell
force-pushed
the
trace-event-metadata-versions
branch
from
566c386 to
c2e2759
Compare
|
Updated .... After talking it over more with @ofrobots ... I removed everything but the node version in this to give us more flexibility later. We need to think about the best approach to handling complex data as opposed to emitting multiple trace events. Emitting the node version covers the most basic use case for this -- that is, knowing what Node.js version generated the trace file -- so it covers the immediate need. |
jasnell
added
the
author ready
Use `TRACE_EVENT_METADATA1` to include just the node.js version for now. Later this can be expanded to include more version and platform details. PR-URL: #20852 Reviewed-By: Ali Ijaz Sheikh <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Richard Lau <[email protected]>
|
Landed in e60eed1 |
Use `TRACE_EVENT_METADATA1` to include just the node.js version for now. Later this can be expanded to include more version and platform details. PR-URL: #20852 Reviewed-By: Ali Ijaz Sheikh <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Richard Lau <[email protected]>
Use
TRACE_EVENT_METADATA1to include Node.js, v8, and libuv versiondetails in the trace log (helpful for log analysis when trace detail
may vary from one Node.js version to another).
/cc @ofrobots
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes