test: revert changes to http2-client-upload-reject #20834
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
setImmediate makes this test flaky due to exposing a bug in http2. Temporarily revert until a fix can be found.
addaleax
approved these changes
May 19, 2018
|
This won't make this test pass 100% of the time. It'll just make it less prone to breakage than it is currently. It will still fail due to the bug that's being exposed by the newer version. The only way to make it not flaky at all is to straight up remove it. But then we would be removing http2-pipe & other tests too :-/ |
4 tasks
|
This is probably better: #20835 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
setImmediate makes this test flaky due to exposing a bug in http2. Temporarily revert until a fix can be found.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes