dns: default to verbatim=true in dns.lookup() #20710

bnoordhuis · 2018-05-14T10:09:01Z

Switch the default from false (reorder the result so that IPv4 addresses
come before IPv6 addresses) to true (return them exactly as the resolver
sent them to us.)

This is intended to be released in Node.js 11.

vsemozhetbyt · 2018-05-14T10:45:11Z

doc/api/dns.md

-    **Default:** currently `false` (addresses are reordered) but this is
-    expected to change in the not too distant future.
-    New code should use `{ verbatim: true }`.
+    IPv4 addresses are placed before IPv6 addresses. **Default:** `true`


Nit: a period after `true` for consistency with the previous option.

I guess that can also be done why landing the PR.

BridgeAR · 2018-05-15T11:23:21Z

CI https://ci.nodejs.org/job/node-test-pull-request/14880/ ❌

Please address the nit while landing.

BridgeAR · 2018-05-18T01:00:36Z

There are lots of related CI failures.

bnoordhuis · 2018-05-18T12:51:21Z

I kinda expected that, I was pretty sure the test suite would be full of assumptions about localhost. I fixed them, PTAL. I also removed common.localhostIPv4, see the commit log for rationale.

https://ci.nodejs.org/job/node-test-pull-request/14958/

BridgeAR

LGTM if CI is green.

jasnell · 2018-05-23T18:15:30Z

Needs a rebase and another CI run after.

BridgeAR · 2018-05-29T18:48:43Z

CI https://ci.nodejs.org/job/node-test-pull-request/15149/

bnoordhuis · 2018-05-29T19:35:32Z

Thanks, Ruben. Looks like there are still some tests to fix up...

jasnell · 2018-08-12T07:30:54Z

ping @bnoordhuis

jasnell · 2018-10-17T16:30:52Z

ping @bnoordhuis

Switch the default from false (reorder the result so that IPv4 addresses come before IPv6 addresses) to true (return them exactly as the resolver sent them to us.) Fixes: nodejs#31566 Refs: nodejs#6307 Refs: nodejs#20710 Reissue of nodejs#31567

Switch the default from false (reorder the result so that IPv4 addresses come before IPv6 addresses) to true (return them exactly as the resolver sent them to us.) Fixes: nodejs#31566 Refs: nodejs#6307 Refs: nodejs#20710 Reissue of nodejs#31567 Reissue of nodejs#37681

Switch the default from false (reorder the result so that IPv4 addresses come before IPv6 addresses) to true (return them exactly as the resolver sent them to us.) Fixes: nodejs#31566 Refs: nodejs#6307 Refs: nodejs#20710 Reissue of nodejs#31567 Reissue of nodejs#37681 Reissue of nodejs#37931

Switch the default from false (reorder the result so that IPv4 addresses come before IPv6 addresses) to true (return them exactly as the resolver sent them to us.) Fixes: nodejs#31566 Refs: nodejs#6307 Refs: nodejs#20710 Refs: nodejs#38099 Reissue of nodejs#31567 Reissue of nodejs#37681 Reissue of nodejs#37931

Switch the default from false (reorder the result so that IPv4 addresses come before IPv6 addresses) to true (return them exactly as the resolver sent them to us.) Fixes: #31566 Refs: #6307 Refs: #20710 Refs: #38099 Reissue of #31567 Reissue of #37681 Reissue of #37931 PR-URL: #39987 Refs: #6307 Refs: #20710 Refs: #38099 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michael Dawson <[email protected]>

PR-URL: #39987 Fixes: #31566 Refs: #6307 Refs: #20710 Refs: #38099 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michael Dawson <[email protected]>

Co-authored-by: Antoine du Hamel <[email protected]> PR-URL: #39987 Fixes: #31566 Refs: #6307 Refs: #20710 Refs: #38099 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michael Dawson <[email protected]>

Switch the default from `ipv4first` to `verbatim` (return them exactly as the resolver sent them to us). PR-URL: #39987 Fixes: #31566 Refs: #6307 Refs: #20710 Refs: #38099 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michael Dawson <[email protected]>

Switch the default from `ipv4first` to `verbatim` (return them exactly as the resolver sent them to us). PR-URL: #39987 Fixes: #31566 Refs: #6307 Refs: #20710 Refs: #38099 Co-authored-by: treysis <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michael Dawson <[email protected]>

bnoordhuis added the semver-major PRs that contain breaking changes and should be released in the next major version. label May 14, 2018

nodejs-github-bot added the dns Issues and PRs related to the dns subsystem. label May 14, 2018

addaleax approved these changes May 14, 2018

View reviewed changes

vsemozhetbyt reviewed May 14, 2018

View reviewed changes

cjihrig approved these changes May 14, 2018

View reviewed changes

BridgeAR approved these changes May 14, 2018

View reviewed changes

trivikr approved these changes May 14, 2018

View reviewed changes

jasnell approved these changes May 14, 2018

View reviewed changes

lpinca approved these changes May 14, 2018

View reviewed changes

BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label May 15, 2018

BridgeAR removed the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label May 18, 2018

bnoordhuis force-pushed the dns-lookup-verbatim-true branch from f1945c9 to 91e03fe Compare May 18, 2018 12:49

BridgeAR approved these changes May 18, 2018

View reviewed changes

bnoordhuis force-pushed the dns-lookup-verbatim-true branch from 91e03fe to b173c9e Compare May 28, 2018 20:50

BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label May 29, 2018

BridgeAR removed the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label May 29, 2018

jasnell added the stalled Issues and PRs that are stalled. label Oct 17, 2018

sam-github approved these changes Oct 17, 2018

View reviewed changes

Trott added this to the 12.0.0 milestone Nov 29, 2018

treysis mentioned this pull request Mar 26, 2021

dns: default to verbatim=true in dns.lookup() #37931

Closed

oyyd mentioned this pull request Apr 5, 2021

dns: allow --dns-verbatim to change default dns verbatim #38099

Merged

treysis mentioned this pull request Sep 3, 2021

dns: default to verbatim=true in dns.lookup() #39987

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

dns: default to verbatim=true in dns.lookup() #20710

dns: default to verbatim=true in dns.lookup() #20710

bnoordhuis commented May 14, 2018

vsemozhetbyt May 14, 2018 •

edited

Loading

BridgeAR May 15, 2018

BridgeAR commented May 15, 2018 •

edited

Loading

BridgeAR commented May 18, 2018

bnoordhuis commented May 18, 2018

BridgeAR left a comment

jasnell commented May 23, 2018

BridgeAR commented May 29, 2018

bnoordhuis commented May 29, 2018

jasnell commented Aug 12, 2018

jasnell commented Oct 17, 2018

dns: default to verbatim=true in dns.lookup() #20710

dns: default to verbatim=true in dns.lookup() #20710

Conversation

bnoordhuis commented May 14, 2018

vsemozhetbyt May 14, 2018 • edited Loading

Choose a reason for hiding this comment

BridgeAR May 15, 2018

Choose a reason for hiding this comment

BridgeAR commented May 15, 2018 • edited Loading

BridgeAR commented May 18, 2018

bnoordhuis commented May 18, 2018

BridgeAR left a comment

Choose a reason for hiding this comment

jasnell commented May 23, 2018

BridgeAR commented May 29, 2018

bnoordhuis commented May 29, 2018

jasnell commented Aug 12, 2018

jasnell commented Oct 17, 2018

vsemozhetbyt May 14, 2018 •

edited

Loading

BridgeAR commented May 15, 2018 •

edited

Loading